From: Christoph Hellwig <hch@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
John Kacur <jkacur@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 5/6] block: remove BKL from partition code
Date: Tue, 6 Jul 2010 22:04:25 -0400 [thread overview]
Message-ID: <20100707020425.GG2950@infradead.org> (raw)
In-Reply-To: <1278193640-24223-6-git-send-email-arnd@arndb.de>
On Sat, Jul 03, 2010 at 11:47:19PM +0200, Arnd Bergmann wrote:
> I don't see any reason why we need the BKL here.
> The functions blkdev_get, blkdev_put, blkpg_ioctl
> and blkdev_reread_part are the only remaining users
> of the big kernel lock in the block layer, and they
> all access the same fields of the bdev and gendisk
> structures, yet they always do so under the protection
> of bdev->bd_mutex.
>
> The open and close block_device_operations have all
> been converted to grab the BKL themselves, where
> necessary, so as far I can tell it should be safe
> to remove.
The content of the patch really does not match the subject at all,
which is a rather bad thing.
Anyway, dropping from blkdev_reread_part and blkpg_ioctl is easy
enough, and fine from a quick audit of the functions.
Dropping it from blkdev_get/put also seems fine from a quick
glance. But that should be part of pushing the BKL into
->open/release.
next prev parent reply other threads:[~2010-07-07 2:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-03 21:47 [PATCH 0/6] block: BKL removal, version 3 Arnd Bergmann
2010-07-03 21:47 ` [PATCH 1/6] block: push down BKL into .locked_ioctl Arnd Bergmann
2010-07-04 7:30 ` Sam Ravnborg
2010-07-04 20:59 ` Arnd Bergmann
2010-07-07 1:52 ` Christoph Hellwig
2010-07-07 13:28 ` Arnd Bergmann
2010-07-03 21:47 ` [PATCH 2/6] block: push down BKL into .open and .release Arnd Bergmann
2010-07-04 8:01 ` Sam Ravnborg
2010-07-04 17:33 ` Arjan van de Ven
2010-07-04 20:27 ` Geert Uytterhoeven
2010-07-04 21:09 ` Arnd Bergmann
2010-07-07 1:50 ` Christoph Hellwig
2010-07-07 14:04 ` Arnd Bergmann
2010-07-03 21:47 ` [PATCH 3/6] block: push BKL into blktrace ioctls Arnd Bergmann
2010-07-07 1:50 ` Christoph Hellwig
2010-07-07 13:46 ` Arnd Bergmann
2010-07-03 21:47 ` [PATCH 4/6] block: remove BKL from BLKROSET and BLKFLSBUF Arnd Bergmann
2010-07-07 1:52 ` Christoph Hellwig
2010-07-03 21:47 ` [PATCH 5/6] block: remove BKL from partition code Arnd Bergmann
2010-07-07 2:04 ` Christoph Hellwig [this message]
2010-07-03 21:47 ` [PATCH 6/6] scsi/sd: remove big kernel lock Arnd Bergmann
2010-07-07 2:06 ` Christoph Hellwig
2010-07-07 13:54 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100707020425.GG2950@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=fweisbec@gmail.com \
--cc=jkacur@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.