Re: [PATCH v4 11/12] Let host know whether the guest can handle async PF in non-userspace context.

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Gleb Natapov <gleb@redhat.com>
To: Rik van Riel <riel@redhat.com>
Cc: kvm@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, avi@redhat.com, mingo@elte.hu,
	a.p.zijlstra@chello.nl, tglx@linutronix.de, hpa@zytor.com,
	cl@linux-foundation.org, mtosatti@redhat.com
Subject: Re: [PATCH v4 11/12] Let host know whether the guest can handle async PF in non-userspace context.
Date: Thu, 8 Jul 2010 16:35:42 +0300	[thread overview]
Message-ID: <20100708133542.GX4689@redhat.com> (raw)
In-Reply-To: <4C3553E2.7020607@redhat.com>

On Thu, Jul 08, 2010 at 12:28:18AM -0400, Rik van Riel wrote:
> On 07/06/2010 12:24 PM, Gleb Natapov wrote:
> >If guest can detect that it runs in non-preemptable context it can
> >handle async PFs at any time, so let host know that it can send async
> >PF even if guest cpu is not in userspace.
> 
> The code looks correct.  One question though - is there a
> reason to implement the userspace-only async PF path at
> all, since the handling of async PF in non-userspace context
> is introduced simultaneously?
> 
Guest userspace-only async PF handling is added in patch 4 and
non-userspace is added in patch 10. It is done for easy reviewing.
If I implement everything in one patch it will be harder to see why
things are done the way they are IMHO.

--
			Gleb.

WARNING: multiple messages have this Message-ID (diff)

From: Gleb Natapov <gleb@redhat.com>
To: Rik van Riel <riel@redhat.com>
Cc: kvm@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, avi@redhat.com, mingo@elte.hu,
	a.p.zijlstra@chello.nl, tglx@linutronix.de, hpa@zytor.com,
	cl@linux-foundation.org, mtosatti@redhat.com
Subject: Re: [PATCH v4 11/12] Let host know whether the guest can handle async PF in non-userspace context.
Date: Thu, 8 Jul 2010 16:35:42 +0300	[thread overview]
Message-ID: <20100708133542.GX4689@redhat.com> (raw)
In-Reply-To: <4C3553E2.7020607@redhat.com>

On Thu, Jul 08, 2010 at 12:28:18AM -0400, Rik van Riel wrote:
> On 07/06/2010 12:24 PM, Gleb Natapov wrote:
> >If guest can detect that it runs in non-preemptable context it can
> >handle async PFs at any time, so let host know that it can send async
> >PF even if guest cpu is not in userspace.
> 
> The code looks correct.  One question though - is there a
> reason to implement the userspace-only async PF path at
> all, since the handling of async PF in non-userspace context
> is introduced simultaneously?
> 
Guest userspace-only async PF handling is added in patch 4 and
non-userspace is added in patch 10. It is done for easy reviewing.
If I implement everything in one patch it will be harder to see why
things are done the way they are IMHO.

--
			Gleb.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

next prev parent reply	other threads:[~2010-07-08 13:36 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-06 16:24 [PATCH v4 00/12] KVM: Add host swap event notifications for PV guest Gleb Natapov
2010-07-06 16:24 ` Gleb Natapov
2010-07-06 16:24 ` [PATCH v4 01/12] Move kvm_smp_prepare_boot_cpu() from kvmclock.c to kvm.c Gleb Natapov
2010-07-06 16:24   ` Gleb Natapov
2010-07-07 16:17   ` Rik van Riel
2010-07-07 16:17     ` Rik van Riel
2010-07-06 16:24 ` [PATCH v4 02/12] Add PV MSR to enable asynchronous page faults delivery Gleb Natapov
2010-07-06 16:24   ` Gleb Natapov
2010-07-07 18:13   ` Rik van Riel
2010-07-07 18:13     ` Rik van Riel
2010-07-06 16:24 ` [PATCH v4 03/12] Add async PF initialization to PV guest Gleb Natapov
2010-07-06 16:24   ` Gleb Natapov
2010-07-07 15:41   ` Peter Zijlstra
2010-07-07 15:41     ` Peter Zijlstra
2010-07-08 13:24     ` Gleb Natapov
2010-07-08 13:24       ` Gleb Natapov
2010-07-06 16:24 ` [PATCH v4 04/12] Provide special async page fault handler when async PF capability is detected Gleb Natapov
2010-07-06 16:24   ` Gleb Natapov
2010-07-07 22:38   ` Rik van Riel
2010-07-07 22:38     ` Rik van Riel
2010-07-06 16:24 ` [PATCH v4 05/12] Export __get_user_pages_fast Gleb Natapov
2010-07-06 16:24   ` Gleb Natapov
2010-07-07 22:45   ` Rik van Riel
2010-07-07 22:45     ` Rik van Riel
2010-07-06 16:24 ` [PATCH v4 06/12] Add get_user_pages() variant that fails if major fault is required Gleb Natapov
2010-07-06 16:24   ` Gleb Natapov
2010-07-06 16:24 ` [PATCH v4 07/12] Maintain memslot version number Gleb Natapov
2010-07-06 16:24   ` Gleb Natapov
2010-07-08  0:19   ` Rik van Riel
2010-07-08  0:19     ` Rik van Riel
2010-07-06 16:24 ` [PATCH v4 08/12] Inject asynchronous page fault into a guest if page is swapped out Gleb Natapov
2010-07-06 16:24   ` Gleb Natapov
2010-07-08  4:09   ` Rik van Riel
2010-07-08  4:09     ` Rik van Riel
2010-07-08 15:59   ` Marcelo Tosatti
2010-07-08 15:59     ` Marcelo Tosatti
2010-07-08 18:05     ` Gleb Natapov
2010-07-08 18:05       ` Gleb Natapov
2010-07-08 18:09       ` Peter Zijlstra
2010-07-08 18:09         ` Peter Zijlstra
2010-07-08 18:10         ` Peter Zijlstra
2010-07-08 18:10           ` Peter Zijlstra
2010-07-09 15:50           ` Gleb Natapov
2010-07-09 15:50             ` Gleb Natapov
2010-07-06 16:24 ` [PATCH v4 09/12] Retry fault before vmentry Gleb Natapov
2010-07-06 16:24   ` Gleb Natapov
2010-07-08  4:21   ` Rik van Riel
2010-07-08  4:21     ` Rik van Riel
2010-07-08 16:17   ` Marcelo Tosatti
2010-07-08 16:17     ` Marcelo Tosatti
2010-07-06 16:24 ` [PATCH v4 10/12] Handle async PF in non preemptable context Gleb Natapov
2010-07-06 16:24   ` Gleb Natapov
2010-07-08  4:22   ` Rik van Riel
2010-07-08  4:22     ` Rik van Riel
2010-07-06 16:24 ` [PATCH v4 11/12] Let host know whether the guest can handle async PF in non-userspace context Gleb Natapov
2010-07-06 16:24   ` Gleb Natapov
2010-07-08  4:28   ` Rik van Riel
2010-07-08  4:28     ` Rik van Riel
2010-07-08 13:35     ` Gleb Natapov [this message]
2010-07-08 13:35       ` Gleb Natapov
2010-07-06 16:25 ` [PATCH v4 12/12] Send async PF when guest is not in userspace too Gleb Natapov
2010-07-06 16:25   ` Gleb Natapov
2010-07-08  4:29   ` Rik van Riel
2010-07-08  4:29     ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100708133542.GX4689@redhat.com \
    --to=gleb@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=avi@redhat.com \
    --cc=cl@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=mtosatti@redhat.com \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.