From: Arnd Bergmann <arnd@arndb.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@infradead.org>,
Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
John Kacur <jkacur@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/7] block: push down BKL into .open and .release
Date: Thu, 8 Jul 2010 13:59:10 +0200 [thread overview]
Message-ID: <201007081359.10760.arnd@arndb.de> (raw)
In-Reply-To: <4C358F29.4020505@kernel.dk>
On Thursday 08 July 2010, Jens Axboe wrote:
> This is missing an smp_lock.h include in i2o as well.
> You seem to only add these sporadically, I think that
> is a bit unsafe since you are relying on unknown
> include hierarchies. That tends to break on one arch
> or config even if it works in another.
The i2o driver is the only one missing smp_lock.h, same problem
as the one you mentioned for patch 2/7. In v3 of the series it
was still correct, I broke it when I rushed out v4.
Arnd
next prev parent reply other threads:[~2010-07-08 11:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 14:51 [PATCH 0/7] block: BKL removal, version 4 Arnd Bergmann
2010-07-07 14:51 ` [PATCH 1/7] scsi/i2o_block: cleanup ioctl handling Arnd Bergmann
2010-07-07 14:51 ` [PATCH 2/7] block: push down BKL into .locked_ioctl Arnd Bergmann
2010-07-08 8:36 ` Jens Axboe
2010-07-08 11:56 ` Arnd Bergmann
2010-07-07 14:51 ` [PATCH 3/7] block: push down BKL into .open and .release Arnd Bergmann
2010-07-08 8:41 ` Jens Axboe
2010-07-08 11:59 ` Arnd Bergmann [this message]
2010-07-07 14:51 ` [PATCH 4/7] block: push BKL into blktrace ioctls Arnd Bergmann
2010-07-07 14:51 ` [PATCH 5/7] block: remove BKL from BLKROSET and BLKFLSBUF Arnd Bergmann
2010-07-07 14:51 ` [PATCH 6/7] block: remove BKL from partition ioctls Arnd Bergmann
2010-07-07 14:51 ` [PATCH 7/7] scsi/sd: remove big kernel lock Arnd Bergmann
2010-07-07 16:44 ` [PATCH 0/7] block: BKL removal, version 4 Christoph Hellwig
2010-07-07 19:36 ` Jens Axboe
2010-07-07 20:18 ` Arnd Bergmann
2010-07-08 8:53 ` Jens Axboe
2010-07-08 12:57 ` [PATCH] scsi/i2o: restore ioctl changes Arnd Bergmann
2010-07-08 12:59 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007081359.10760.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=jkacur@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.