From: Jens Axboe <axboe@kernel.dk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Christoph Hellwig <hch@infradead.org>,
Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
John Kacur <jkacur@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/7] block: push down BKL into .locked_ioctl
Date: Thu, 08 Jul 2010 10:36:15 +0200 [thread overview]
Message-ID: <4C358DFF.9090401@kernel.dk> (raw)
In-Reply-To: <1278514289-21054-3-git-send-email-arnd@arndb.de>
On 2010-07-07 16:51, Arnd Bergmann wrote:
> As a preparation for the removal of the big kernel
> lock in the block layer, this removes the BKL
> from the common ioctl handling code, moving it
> into every single driver still using it.
>
> diff --git a/drivers/message/i2o/i2o_block.c b/drivers/message/i2o/i2o_block.c
> index ad3ddef..fc593fb 100644
> --- a/drivers/message/i2o/i2o_block.c
> +++ b/drivers/message/i2o/i2o_block.c
> @@ -941,8 +930,7 @@ static const struct block_device_operations i2o_block_fops = {
> .owner = THIS_MODULE,
> .open = i2o_block_open,
> .release = i2o_block_release,
> - .ioctl = i2o_block_ioctl,
> - .compat_ioctl = i2o_block_ioctl,
> + .locked_ioctl = i2o_block_ioctl,
> .getgeo = i2o_block_getgeo,
> .media_changed = i2o_block_media_changed
> };
Hmm?
--
Jens Axboe
next prev parent reply other threads:[~2010-07-08 8:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 14:51 [PATCH 0/7] block: BKL removal, version 4 Arnd Bergmann
2010-07-07 14:51 ` [PATCH 1/7] scsi/i2o_block: cleanup ioctl handling Arnd Bergmann
2010-07-07 14:51 ` [PATCH 2/7] block: push down BKL into .locked_ioctl Arnd Bergmann
2010-07-08 8:36 ` Jens Axboe [this message]
2010-07-08 11:56 ` Arnd Bergmann
2010-07-07 14:51 ` [PATCH 3/7] block: push down BKL into .open and .release Arnd Bergmann
2010-07-08 8:41 ` Jens Axboe
2010-07-08 11:59 ` Arnd Bergmann
2010-07-07 14:51 ` [PATCH 4/7] block: push BKL into blktrace ioctls Arnd Bergmann
2010-07-07 14:51 ` [PATCH 5/7] block: remove BKL from BLKROSET and BLKFLSBUF Arnd Bergmann
2010-07-07 14:51 ` [PATCH 6/7] block: remove BKL from partition ioctls Arnd Bergmann
2010-07-07 14:51 ` [PATCH 7/7] scsi/sd: remove big kernel lock Arnd Bergmann
2010-07-07 16:44 ` [PATCH 0/7] block: BKL removal, version 4 Christoph Hellwig
2010-07-07 19:36 ` Jens Axboe
2010-07-07 20:18 ` Arnd Bergmann
2010-07-08 8:53 ` Jens Axboe
2010-07-08 12:57 ` [PATCH] scsi/i2o: restore ioctl changes Arnd Bergmann
2010-07-08 12:59 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C358DFF.9090401@kernel.dk \
--to=axboe@kernel.dk \
--cc=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=jkacur@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.