All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "Michał Nazarewicz" <m.nazarewicz@samsung.com>
Cc: linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
	David Brownell <dbrownell@users.sourceforge.net>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-kernel@vger.kernel.org,
	Dries Van Puymbroeck <Dries.VanPuymbroeck@dekimo.com>,
	stable <stable@kernel.org>
Subject: Re: [PATCHv2 1/2] USB: gadget: mass/file storage: set serial number
Date: Thu, 8 Jul 2010 12:03:28 -0700	[thread overview]
Message-ID: <20100708190328.GA6617@kroah.com> (raw)
In-Reply-To: <op.vfjga9ie7p4s8u@pikus>

On Thu, Jul 08, 2010 at 08:58:11PM +0200, Michał Nazarewicz wrote:
> >On Thu, Jul 01, 2010 at 03:42:19PM +0200, Michal Nazarewicz wrote:
> >>This commit adds iSerialNumber to all gadgets that use the Mass
> >>Storage Function.  It appears that Windows has problems when
> >>it is not set.
> >>
> >>Not to copy the same code all over again, a fsg_string_serial_fill()
> >>macro has been added to the storage_common.c file which is now also
> >>used in the File Storage Gadget.
> 
> On Thu, 08 Jul 2010 20:34:25 +0200, Greg KH <greg@kroah.com> wrote:
> >This patch conflicts with the patch in my tree:
> >	Subject: USB: Add a serial number parameter to g_file_storage module
> 
> Ah, there it is...  I remembered this patch but couldn't find it so assumed
> that it didn't make it to your tree after all.  But there it is...
> 
> >So, could you fix the above patch up to play nice with your change so
> >that I can accept it?
> 
> Sure thing.  If I won't post it within 2h I'll do that after the weekend
> (read Monday).

Sounds good.

Note, Monday I'll be somewhere in Europe so my email access might be a
bit limited for that week.

thanks,

greg k-h

  reply	other threads:[~2010-07-08 19:03 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-01  9:17 [PATCH 1/2] USB: gadget: mass/file storage: set serial number Michal Nazarewicz
2010-07-01  9:17 ` [PATCH 2/2] " Michal Nazarewicz
2010-07-01 10:27 ` [PATCH 1/2] " Michał Nazarewicz
2010-07-01 13:42 ` [PATCHv2 " Michal Nazarewicz
2010-07-01 13:42   ` [PATCHv2 2/2] USB: gadget: g_multi: code clean up and refactoring Michal Nazarewicz
2010-07-08 18:34   ` [PATCHv2 1/2] USB: gadget: mass/file storage: set serial number Greg KH
2010-07-08 18:58     ` Michał Nazarewicz
2010-07-08 19:03       ` Greg KH [this message]
2010-07-08 19:31       ` David Brownell
2010-07-08 20:02         ` Michał Nazarewicz
2010-07-08 20:20           ` David Brownell
2010-07-08 20:27             ` Michał Nazarewicz
2010-07-08 20:52     ` [PATCHv3 1/3] " Michal Nazarewicz
2010-07-08 20:52       ` [PATCHv3 2/3] USB: Add a serial number parameter to g_file_storage module Michal Nazarewicz
2010-07-08 20:52         ` [PATCHv3 3/3] USB: gadget: g_multi: code clean up and refactoring Michal Nazarewicz
2010-07-09 19:04       ` [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number Greg KH
2010-07-17 23:01         ` Michał Nazarewicz
2010-07-17 23:57           ` David Brownell
2010-07-19  8:58             ` Michał Nazarewicz
2010-07-19 10:08               ` David Brownell
2010-07-19 12:07                 ` Michał Nazarewicz
2010-07-19 14:19                   ` Alan Stern
2010-07-19 15:02                     ` Michał Nazarewicz
2010-07-19 16:14                       ` Alan Stern
2010-07-19 16:26                         ` Michał Nazarewicz
2010-07-19 17:06                           ` Alan Stern
2010-07-19 17:21                             ` Michał Nazarewicz
2010-07-19 17:41                               ` David Brownell
2010-07-20  8:41                                 ` Michał Nazarewicz
2010-07-20 14:07                                   ` Alan Stern
2010-07-20 14:43                                     ` Michał Nazarewicz
2010-07-20 15:01                                   ` David Brownell
2010-07-20 15:45                                     ` Michał Nazarewicz
2010-07-19 18:37                               ` Alan Stern
2010-07-20  9:57                             ` Michał Nazarewicz
2010-07-20 14:08                               ` Alan Stern
2010-07-20 14:40                                 ` Michał Nazarewicz
2010-07-20 14:52                                   ` David Brownell
2010-07-20 15:02                                   ` Alan Stern
2010-07-19 14:44                   ` David Brownell
2010-07-19 15:01                     ` Michał Nazarewicz
2010-07-22 12:16       ` [PATCHv4 1/5] USB: gadget: composite: Better string override handling Michal Nazarewicz
2010-07-22 12:16         ` [PATCHv4 2/5] USB: gadget: Use new composite features in some gadgets Michal Nazarewicz
2010-07-22 12:16           ` [PATCHv4 3/5] USB: gadget: g_multi: code clean up and refactoring Michal Nazarewicz
2010-07-22 12:16             ` [PATCHv4 4/5] USB: gadget: g_fs: code cleanup Michal Nazarewicz
2010-07-22 12:16               ` [PATCHv4 5/5] USB: gadget: file_storage: serial parameter even if not test mode Michal Nazarewicz
2010-07-22 14:14                 ` Alan Stern
2010-07-22 23:46         ` [PATCHv4 1/5] USB: gadget: composite: Better string override handling Greg KH
2010-07-23  9:04           ` Michał Nazarewicz
2010-07-27  6:53           ` David Brownell
2010-07-26 21:28         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100708190328.GA6617@kroah.com \
    --to=greg@kroah.com \
    --cc=Dries.VanPuymbroeck@dekimo.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.nazarewicz@samsung.com \
    --cc=m.szyprowski@samsung.com \
    --cc=stable@kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.