From: "Michał Nazarewicz" <m.nazarewicz@samsung.com>
To: Greg KH <greg@kroah.com>, David Brownell <david-b@pacbell.net>
Cc: linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org,
Dries Van Puymbroeck <Dries.VanPuymbroeck@dekimo.com>,
mina86@mina86.com
Subject: Re: [PATCHv2 1/2] USB: gadget: mass/file storage: set serial number
Date: Thu, 08 Jul 2010 22:02:56 +0200 [thread overview]
Message-ID: <op.vfjja62m7p4s8u@pikus> (raw)
In-Reply-To: <752897.66667.qm@web180316.mail.gq1.yahoo.com>
>> >> This commit adds iSerialNumber to all gadgets that
>> use the Mass Storage Function.
On Thu, 08 Jul 2010 21:31:23 +0200, David Brownell <david-b@pacbell.net> wrote:
> Can it be made to do so only when the gadget
> hasn't been provided with one already? Serial
> number module options are standard parts of the
> composite gadget framework...
I don't see a way for the gadget to know whether user gave the iSerialNumber
parameter (other then reading the iSerialNumber variable but I consider that
ugly).
Plus, in any event, gadget has to reserve a string ID for serial number
anyway. Otherwise composite won't override the string.
PS. I've just spotted a bug in Yann's patch (string is not filled if
CONFIG_USB_FILE_STORAGE_TEST is undefined). It's a trivial issue so
I'll fix it with updated version.
--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
next prev parent reply other threads:[~2010-07-08 20:01 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 9:17 [PATCH 1/2] USB: gadget: mass/file storage: set serial number Michal Nazarewicz
2010-07-01 9:17 ` [PATCH 2/2] " Michal Nazarewicz
2010-07-01 10:27 ` [PATCH 1/2] " Michał Nazarewicz
2010-07-01 13:42 ` [PATCHv2 " Michal Nazarewicz
2010-07-01 13:42 ` [PATCHv2 2/2] USB: gadget: g_multi: code clean up and refactoring Michal Nazarewicz
2010-07-08 18:34 ` [PATCHv2 1/2] USB: gadget: mass/file storage: set serial number Greg KH
2010-07-08 18:58 ` Michał Nazarewicz
2010-07-08 19:03 ` Greg KH
2010-07-08 19:31 ` David Brownell
2010-07-08 20:02 ` Michał Nazarewicz [this message]
2010-07-08 20:20 ` David Brownell
2010-07-08 20:27 ` Michał Nazarewicz
2010-07-08 20:52 ` [PATCHv3 1/3] " Michal Nazarewicz
2010-07-08 20:52 ` [PATCHv3 2/3] USB: Add a serial number parameter to g_file_storage module Michal Nazarewicz
2010-07-08 20:52 ` [PATCHv3 3/3] USB: gadget: g_multi: code clean up and refactoring Michal Nazarewicz
2010-07-09 19:04 ` [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number Greg KH
2010-07-17 23:01 ` Michał Nazarewicz
2010-07-17 23:57 ` David Brownell
2010-07-19 8:58 ` Michał Nazarewicz
2010-07-19 10:08 ` David Brownell
2010-07-19 12:07 ` Michał Nazarewicz
2010-07-19 14:19 ` Alan Stern
2010-07-19 15:02 ` Michał Nazarewicz
2010-07-19 16:14 ` Alan Stern
2010-07-19 16:26 ` Michał Nazarewicz
2010-07-19 17:06 ` Alan Stern
2010-07-19 17:21 ` Michał Nazarewicz
2010-07-19 17:41 ` David Brownell
2010-07-20 8:41 ` Michał Nazarewicz
2010-07-20 14:07 ` Alan Stern
2010-07-20 14:43 ` Michał Nazarewicz
2010-07-20 15:01 ` David Brownell
2010-07-20 15:45 ` Michał Nazarewicz
2010-07-19 18:37 ` Alan Stern
2010-07-20 9:57 ` Michał Nazarewicz
2010-07-20 14:08 ` Alan Stern
2010-07-20 14:40 ` Michał Nazarewicz
2010-07-20 14:52 ` David Brownell
2010-07-20 15:02 ` Alan Stern
2010-07-19 14:44 ` David Brownell
2010-07-19 15:01 ` Michał Nazarewicz
2010-07-22 12:16 ` [PATCHv4 1/5] USB: gadget: composite: Better string override handling Michal Nazarewicz
2010-07-22 12:16 ` [PATCHv4 2/5] USB: gadget: Use new composite features in some gadgets Michal Nazarewicz
2010-07-22 12:16 ` [PATCHv4 3/5] USB: gadget: g_multi: code clean up and refactoring Michal Nazarewicz
2010-07-22 12:16 ` [PATCHv4 4/5] USB: gadget: g_fs: code cleanup Michal Nazarewicz
2010-07-22 12:16 ` [PATCHv4 5/5] USB: gadget: file_storage: serial parameter even if not test mode Michal Nazarewicz
2010-07-22 14:14 ` Alan Stern
2010-07-22 23:46 ` [PATCHv4 1/5] USB: gadget: composite: Better string override handling Greg KH
2010-07-23 9:04 ` Michał Nazarewicz
2010-07-27 6:53 ` David Brownell
2010-07-26 21:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.vfjja62m7p4s8u@pikus \
--to=m.nazarewicz@samsung.com \
--cc=Dries.VanPuymbroeck@dekimo.com \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mina86@mina86.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.