Question about SuperH HDMI sound

Question about SuperH HDMI sound

[Kuninori Morimoto]

Dear Mark
Cc: Guennadi

In these days, Guennadi's "SuperH HDMI support patches"
which support HDMI video output were posted to ML.
And I created HDMI sound support for it in my local environment.
It works and I would like to post this patch.

Thus, I would like to ask you about HDMI "sound" support file position.

HDMI "video" support file is under "drivers/video/sh_mobile_hdmi.c"
Should I add sound support in it ? or under "sound/soc/codecs" ?

Best regards
--
Kuninori Morimoto

Re: Question about SuperH HDMI sound

[Mark Brown]

On Fri, Jul 09, 2010 at 09:19:24AM +0900, Kuninori Morimoto wrote:

> HDMI "video" support file is under "drivers/video/sh_mobile_hdmi.c"
> Should I add sound support in it ? or under "sound/soc/codecs" ?

One or the other :)

On PCs there is support for HDMI audio within the HDA subsystem so it
would seem reasonable to add the support in ASoC if the hardware shares
anything with the rest of the audio hardware in the SoC.  It may also
make sense to provide a driver which presents both video and audio
interfaces, depending on how the hardware is structured.

If the hardware doesn't share anything with the other audio hardware
then it might be as easy to just implement outside ASoC as a regular
ALSA driver since HDMI "CODECs" are usually the TVs or other remote
devices that are plugged in to the system rather than a component of the
system itself so the CODEC/CPU split of ASoC isn't such a clear benefit.

Re: Question about SuperH HDMI sound

[Kuninori Morimoto]

Dear Mark

Thank you for response

> > HDMI "video" support file is under "drivers/video/sh_mobile_hdmi.c"
> > Should I add sound support in it ? or under "sound/soc/codecs" ?
(snip)
> make sense to provide a driver which presents both video and audio
> interfaces, depending on how the hardware is structured.

I use above idea. Thanks.

I send this patch after SH HDMI video support patch was applied.

Best regards
--
Kuninori Morimoto

Re: Question about SuperH HDMI sound

[Kuninori Morimoto]

Dear Mark

Thank you for response

> > HDMI "video" support file is under "drivers/video/sh_mobile_hdmi.c"
> > Should I add sound support in it ? or under "sound/soc/codecs" ?
(snip)
> make sense to provide a driver which presents both video and audio
> interfaces, depending on how the hardware is structured.

I use above idea. Thanks.

I send this patch after SH HDMI video support patch was applied.

Best regards
--
Kuninori Morimoto