All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: cleanup lvds detection function
@ 2010-07-09 17:47 Jesse Barnes
  0 siblings, 0 replies; only message in thread
From: Jesse Barnes @ 2010-07-09 17:47 UTC (permalink / raw)
  To: intel-gfx, eric

This function and its description were confusing at best.  Clean them up to
reflect the current state of things.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
index 0eab8df..6bc313a 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -542,22 +542,14 @@ static void intel_lvds_mode_set(struct drm_encoder *encoder,
 /**
  * Detect the LVDS connection.
  *
- * Since LVDS doesn't have hotlug, we use the lid as a proxy.  Open means
- * connected and closed means disconnected.  We also send hotplug events as
- * needed, using lid status notification from the input layer.
+ * Note: it would be nice to use lid state as a proxy here, but actual state is
+ * not widely available (either it doesn't exist or is broken on many platforms)
+ * so just return connector_status_connected at all times, since this function
+ * is only called if an LVDS display is detected at init time.
  */
 static enum drm_connector_status intel_lvds_detect(struct drm_connector *connector)
 {
-	struct drm_device *dev = connector->dev;
-	enum drm_connector_status status = connector_status_connected;
-
-	/* ACPI lid methods were generally unreliable in this generation, so
-	 * don't even bother.
-	 */
-	if (IS_GEN2(dev) || IS_GEN3(dev))
-		return connector_status_connected;
-
-	return status;
+	return connector_status_connected;
 }
 
 /**

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-07-09 17:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-09 17:47 [PATCH] drm/i915: cleanup lvds detection function Jesse Barnes

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.