From: Dan Carpenter <error27@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jiri Pirko <jpirko@redhat.com>, Joe Perches <joe@perches.com>,
Stephen Hemminger <shemminger@vyatta.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] at1700: fix double free_irq
Date: Fri, 09 Jul 2010 18:56:16 +0000 [thread overview]
Message-ID: <20100709185616.GO19184@bicker> (raw)
In-Reply-To: <20100709174809.GA5228@albatros>
On Fri, Jul 09, 2010 at 09:48:09PM +0400, Kulikov Vasiliy wrote:
> > > /* Disable the IRQ on boards of fmv18x where it is feasible. */
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >
> > It seems like this comment should be updated?
>
> Maybe yes, but I don't know what these damn IO requests mean.
> Sure, it's better to request IRQ in xxx_open(), but as it is already
> done in probe() I leave it here.
>
> If it is a bug then I do nothing with it, but if it is not then I'll
> create a bug.
>
Yeah. I see what you mean. You are probably right. It should be easy
to test if anyone had the hardware. But this driver is 17 years old so
I doubt anyone does. :P
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jiri Pirko <jpirko@redhat.com>, Joe Perches <joe@perches.com>,
Stephen Hemminger <shemminger@vyatta.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] at1700: fix double free_irq
Date: Fri, 9 Jul 2010 20:56:16 +0200 [thread overview]
Message-ID: <20100709185616.GO19184@bicker> (raw)
In-Reply-To: <20100709174809.GA5228@albatros>
On Fri, Jul 09, 2010 at 09:48:09PM +0400, Kulikov Vasiliy wrote:
> > > /* Disable the IRQ on boards of fmv18x where it is feasible. */
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >
> > It seems like this comment should be updated?
>
> Maybe yes, but I don't know what these damn IO requests mean.
> Sure, it's better to request IRQ in xxx_open(), but as it is already
> done in probe() I leave it here.
>
> If it is a bug then I do nothing with it, but if it is not then I'll
> create a bug.
>
Yeah. I see what you mean. You are probably right. It should be easy
to test if anyone had the hardware. But this driver is 17 years old so
I doubt anyone does. :P
regards,
dan carpenter
next prev parent reply other threads:[~2010-07-09 18:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 12:31 [PATCH] at1700: fix double free_irq Kulikov Vasiliy
2010-07-09 12:31 ` Kulikov Vasiliy
2010-07-09 16:58 ` Dan Carpenter
2010-07-09 16:58 ` Dan Carpenter
2010-07-09 17:48 ` Kulikov Vasiliy
2010-07-09 17:48 ` Kulikov Vasiliy
2010-07-09 18:56 ` Dan Carpenter [this message]
2010-07-09 18:56 ` Dan Carpenter
2010-07-12 1:15 ` David Miller
2010-07-12 1:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100709185616.GO19184@bicker \
--to=error27@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=jpirko@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=segooon@gmail.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.