All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kulikov Vasiliy <segooon@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
	Simon Kelley <simon@thekelleys.org.uk>,
	"John W. Linville" <linville@tuxdriver.com>,
	"David S. Miller" <davem@davemloft.net>,
	Stephen Hemminger <shemminger@vyatta.com>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Ben Hutchings <ben@decadent.org.uk>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] atmel: unregister_netdev() on error
Date: Sat, 10 Jul 2010 16:38:53 +0000	[thread overview]
Message-ID: <20100710163853.GA4695@albatros> (raw)
In-Reply-To: <20100710141204.GY19184@bicker>

On Sat, Jul 10, 2010 at 16:12 +0200, Dan Carpenter wrote:
> > +err_out_unreg:
> > +	unregister_netdev(dev);
> 	^^^^^^^^^^^^^^^^^^^^^^
> > +
> 
> What the pants?  :P
Hmm, I've slightly misunderstood the code, sorry.

Thanks, Dan.

WARNING: multiple messages have this Message-ID (diff)
From: Kulikov Vasiliy <segooon@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
	Simon Kelley <simon@thekelleys.org.uk>,
	"John W. Linville" <linville@tuxdriver.com>,
	"David S. Miller" <davem@davemloft.net>,
	Stephen Hemminger <shemminger@vyatta.com>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Ben Hutchings <ben@decadent.org.uk>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] atmel: unregister_netdev() on error
Date: Sat, 10 Jul 2010 20:38:53 +0400	[thread overview]
Message-ID: <20100710163853.GA4695@albatros> (raw)
In-Reply-To: <20100710141204.GY19184@bicker>

On Sat, Jul 10, 2010 at 16:12 +0200, Dan Carpenter wrote:
> > +err_out_unreg:
> > +	unregister_netdev(dev);
> 	^^^^^^^^^^^^^^^^^^^^^^
> > +
> 
> What the pants?  :P
Hmm, I've slightly misunderstood the code, sorry.

Thanks, Dan.

  reply	other threads:[~2010-07-10 16:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-10 13:11 [PATCH] atmel: unregister_netdev() on error Kulikov Vasiliy
2010-07-10 13:11 ` Kulikov Vasiliy
2010-07-10 14:12 ` Dan Carpenter
2010-07-10 14:12   ` Dan Carpenter
2010-07-10 14:12   ` Dan Carpenter
2010-07-10 16:38   ` Kulikov Vasiliy [this message]
2010-07-10 16:38     ` Kulikov Vasiliy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100710163853.GA4695@albatros \
    --to=segooon@gmail.com \
    --cc=ben@decadent.org.uk \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=error27@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    --cc=simon@thekelleys.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.