Re: [PATCH v2] x86: Early-boot serial I/O support

[Cyrill Gorcunov <gorcunov@gmail.com>]

On Sun, Jul 11, 2010 at 12:18:06AM +0300, Pekka Enberg wrote:
> On Sun, Jul 11, 2010 at 12:07 AM, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> >> @@ -203,6 +205,17 @@ static inline int isdigit(int ch)
> >>       return (ch >= '0') && (ch <= '9');
> >>  }
> >>
> >> +static inline int isxdigit(int ch)
> >> +{
> >> +     if (isdigit(ch))
> >> +             return true;
> >> +
> >> +     if ((ch >= 'a') && (ch <= 'f'))
> >> +             return true;
> >> +
> >> +     return (ch >= 'A') && (ch <= 'F');
> >> +}
> >> +
> >
> > I suspect it's supposed to be static inline *bool*, right?
> 
> Yes, but I followed 'isdigit' here for symmetry and it uses 'int'.
> 
>                        Pekka
> 

ok, I see

	-- Cyrill