From: "H. Peter Anvin" <hpa@zytor.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>, Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH v2] x86: Early-boot serial I/O support
Date: Sat, 10 Jul 2010 14:36:10 -0700 [thread overview]
Message-ID: <4C38E7CA.30100@zytor.com> (raw)
In-Reply-To: <20100710213211.GD6615@lenovo>
On 07/10/2010 02:32 PM, Cyrill Gorcunov wrote:
>>
>> Yes, but I followed 'isdigit' here for symmetry and it uses 'int'.
>>
>
> ok, I see
>
At the time the code was written, "bool" use in the kernel was still not
really accepted as a matter of style. I think that has changed now and
"bool" is preferred, except as input/output to asm statements (we don't
yet trust gcc to do it sanely across versions.)
As such, changing that would be good, but should be done as a separate
thing.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2010-07-10 21:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-10 19:40 [PATCH v2] x86: Early-boot serial I/O support Pekka Enberg
2010-07-10 20:49 ` Yinghai Lu
2010-07-10 21:17 ` Pekka Enberg
2010-07-10 21:27 ` H. Peter Anvin
2010-07-10 21:32 ` Pekka Enberg
2010-07-10 21:07 ` Cyrill Gorcunov
2010-07-10 21:18 ` Pekka Enberg
2010-07-10 21:32 ` Cyrill Gorcunov
2010-07-10 21:36 ` H. Peter Anvin [this message]
2010-07-10 21:37 ` H. Peter Anvin
2010-07-10 21:55 ` Cyrill Gorcunov
2010-07-10 22:30 ` H. Peter Anvin
2010-07-11 7:10 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C38E7CA.30100@zytor.com \
--to=hpa@zytor.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=penberg@cs.helsinki.fi \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.