Re: [Qemu-devel] [RFC PATCH 1/7] Generic IOMMU layer

[Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>]

On Wed, Jul 14, 2010 at 10:07:20AM +0400, malc wrote:
> On Wed, 14 Jul 2010, Eduard - Gabriel Munteanu wrote:
> 
> > This provides an API for abstracting IOMMU functions. Hardware emulation
> > code can use it to request address translation and access checking. In
> > the absence of an emulated IOMMU, no translation/checking happens and
> > I/O goes through as before.
> > 
> > IOMMU emulation code must provide implementation-specific hooks for this
> > layer.
> > 
> 
> [..snip..]
> 
> > +int __iommu_rw(struct iommu *iommu,
> > +               DeviceState *dev,
> > +               target_phys_addr_t addr,
> > +               uint8_t *buf,
> > +               int len,
> > +               int is_write)
> 
> Do not use leading double underscore.
> 
> [..snip..]
> 
> -- 
> mailto:av1474@comtv.ru

Thanks, will fix it.


	Eduard