From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfs: don't block on buffer read errors
Date: Thu, 15 Jul 2010 10:05:52 +1000 [thread overview]
Message-ID: <20100715000552.GE30737@dastard> (raw)
In-Reply-To: <20100714182836.GA12108@infradead.org>
On Wed, Jul 14, 2010 at 02:28:36PM -0400, Christoph Hellwig wrote:
> Looks good, except that I'd rework the snipplet below
>
> > status = xfs_buf_iorequest(bp);
> > - if (!status && !(flags & XBF_ASYNC))
> > + if (!(status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC)))
> > status = xfs_buf_iowait(bp);
> > return status;
>
> as:
>
> if (status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC))
> return status;
> return xfs_buf_iowait(bp);
>
> to make it a bit more clear.
Make sense. Fixed it up.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com, axboe@kernel.dk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: don't block on buffer read errors
Date: Thu, 15 Jul 2010 10:05:52 +1000 [thread overview]
Message-ID: <20100715000552.GE30737@dastard> (raw)
In-Reply-To: <20100714182836.GA12108@infradead.org>
On Wed, Jul 14, 2010 at 02:28:36PM -0400, Christoph Hellwig wrote:
> Looks good, except that I'd rework the snipplet below
>
> > status = xfs_buf_iorequest(bp);
> > - if (!status && !(flags & XBF_ASYNC))
> > + if (!(status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC)))
> > status = xfs_buf_iowait(bp);
> > return status;
>
> as:
>
> if (status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC))
> return status;
> return xfs_buf_iowait(bp);
>
> to make it a bit more clear.
Make sense. Fixed it up.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2010-07-15 0:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 7:50 [PATCH 0/2] Graceful failures for XFS on an unconfigured loop device Dave Chinner
2010-07-13 7:50 ` Dave Chinner
2010-07-13 7:50 ` [PATCH 1/2] xfs: don't block on buffer read errors Dave Chinner
2010-07-13 7:50 ` Dave Chinner
2010-07-14 18:28 ` Christoph Hellwig
2010-07-14 18:28 ` Christoph Hellwig
2010-07-15 0:05 ` Dave Chinner [this message]
2010-07-15 0:05 ` Dave Chinner
2010-07-13 7:50 ` [PATCH 2/2] blkdev: check for valid request queue before issuing flush Dave Chinner
2010-07-13 7:50 ` Dave Chinner
2010-07-13 12:55 ` Jens Axboe
2010-07-13 12:55 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100715000552.GE30737@dastard \
--to=david@fromorbit.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.