From: Andrew Morton <akpm@linux-foundation.org>
To: Maurus Cuelenaere <mcuelenaere@gmail.com>
Cc: linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
ben-linux@fluff.org
Subject: Re: [PATCH v2] s3c-fb: Automatically calculate pixel clock when
Date: Thu, 15 Jul 2010 19:37:00 +0000 [thread overview]
Message-ID: <20100715123700.d7efd3a1.akpm@linux-foundation.org> (raw)
In-Reply-To: <4C3F6023.5080002@gmail.com>
On Thu, 15 Jul 2010 21:23:15 +0200
Maurus Cuelenaere <mcuelenaere@gmail.com> wrote:
> Op 15-07-10 20:52, Andrew Morton schreef:
> > On Tue, 13 Jul 2010 02:05:45 +0200
> > Maurus Cuelenaere <mcuelenaere@gmail.com> wrote:
> >
> >> This patch adds a simple algorithm which calculates the pixel clock based on the
> >> video mode parameters. This is only done when no pixel clock is supplied through
> >> the platform data.
> >>
> > So.. we are to assume that there's a platform which doesn't provide
> > the pixel clock data? Adding some information about that in the
> > changelog would have been useful.
>
> Not exactly, this allows you to omit the pixel clock data and thus sharing the
> "algo" used for calculating it; which is done in another patch (not submitted to
> linux-fbdev, see [1]).
>
> [1] - http://www.spinics.net/lists/linux-samsung-soc/msg02086.html
>
That means that there's no reason to merge this patch!
So I merged "arm: samsung: remove pixclock from several boards" as well ;)
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Maurus Cuelenaere <mcuelenaere@gmail.com>
Cc: linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
ben-linux@fluff.org
Subject: Re: [PATCH v2] s3c-fb: Automatically calculate pixel clock when none is given
Date: Thu, 15 Jul 2010 12:37:00 -0700 [thread overview]
Message-ID: <20100715123700.d7efd3a1.akpm@linux-foundation.org> (raw)
In-Reply-To: <4C3F6023.5080002@gmail.com>
On Thu, 15 Jul 2010 21:23:15 +0200
Maurus Cuelenaere <mcuelenaere@gmail.com> wrote:
> Op 15-07-10 20:52, Andrew Morton schreef:
> > On Tue, 13 Jul 2010 02:05:45 +0200
> > Maurus Cuelenaere <mcuelenaere@gmail.com> wrote:
> >
> >> This patch adds a simple algorithm which calculates the pixel clock based on the
> >> video mode parameters. This is only done when no pixel clock is supplied through
> >> the platform data.
> >>
> > So.. we are to assume that there's a platform which doesn't provide
> > the pixel clock data? Adding some information about that in the
> > changelog would have been useful.
>
> Not exactly, this allows you to omit the pixel clock data and thus sharing the
> "algo" used for calculating it; which is done in another patch (not submitted to
> linux-fbdev, see [1]).
>
> [1] - http://www.spinics.net/lists/linux-samsung-soc/msg02086.html
>
That means that there's no reason to merge this patch!
So I merged "arm: samsung: remove pixclock from several boards" as well ;)
next prev parent reply other threads:[~2010-07-15 19:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 0:05 [PATCH v2] s3c-fb: Automatically calculate pixel clock when none is given Maurus Cuelenaere
2010-07-13 0:05 ` Maurus Cuelenaere
2010-07-13 3:14 ` [PATCH v2] s3c-fb: Automatically calculate pixel clock when none yiffie9819
2010-07-13 3:14 ` [PATCH v2] s3c-fb: Automatically calculate pixel clock when none is given yiffie9819
2010-07-15 18:52 ` [PATCH v2] s3c-fb: Automatically calculate pixel clock when Andrew Morton
2010-07-15 18:52 ` [PATCH v2] s3c-fb: Automatically calculate pixel clock when none is given Andrew Morton
2010-07-15 19:23 ` [PATCH v2] s3c-fb: Automatically calculate pixel clock when none Maurus Cuelenaere
2010-07-15 19:23 ` [PATCH v2] s3c-fb: Automatically calculate pixel clock when none is given Maurus Cuelenaere
2010-07-15 19:37 ` Andrew Morton [this message]
2010-07-15 19:37 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100715123700.d7efd3a1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mcuelenaere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.