From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] xfs: track AGs with reclaimable inodes in per-ag radix tree
Date: Thu, 15 Jul 2010 14:12:28 -0400 [thread overview]
Message-ID: <20100715181228.GC14554@infradead.org> (raw)
In-Reply-To: <1279194418-16119-4-git-send-email-david@fromorbit.com>
> + */
> +static struct xfs_perag *
> +xfs_inode_ag_iter_next_pag(
> + struct xfs_mount *mp,
> + xfs_agnumber_t *first,
> + int tag)
> +{
> + struct xfs_perag *pag = NULL;
> +
> + if (tag == XFS_ICI_RECLAIM_TAG) {
> + int found;
> + int ref;
> +
> + spin_lock(&mp->m_perag_lock);
> + found = radix_tree_gang_lookup_tag(&mp->m_perag_tree,
> + (void **)&pag, *first, 1, tag);
> + if (found <= 0) {
> + spin_unlock(&mp->m_perag_lock);
> + return NULL;
> + }
> + *first = pag->pag_agno + 1;
> + /* open coded pag reference increment */
> + ref = atomic_inc_return(&pag->pag_ref);
> + spin_unlock(&mp->m_perag_lock);
> + trace_xfs_perag_get_reclaim(mp, pag->pag_agno, ref, _RET_IP_);
> + } else {
> + pag = xfs_perag_get(mp, *first);
> + (*first)++;
> + }
I wonder if we should just split the AG iterator for inode reclaim vs
the rest. We now have this difference in addition to taking the per-AG
lock exclusive instead of shared.
Anyway, the patch looks good for now,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 3/3] xfs: track AGs with reclaimable inodes in per-ag radix tree
Date: Thu, 15 Jul 2010 14:12:28 -0400 [thread overview]
Message-ID: <20100715181228.GC14554@infradead.org> (raw)
In-Reply-To: <1279194418-16119-4-git-send-email-david@fromorbit.com>
> + */
> +static struct xfs_perag *
> +xfs_inode_ag_iter_next_pag(
> + struct xfs_mount *mp,
> + xfs_agnumber_t *first,
> + int tag)
> +{
> + struct xfs_perag *pag = NULL;
> +
> + if (tag == XFS_ICI_RECLAIM_TAG) {
> + int found;
> + int ref;
> +
> + spin_lock(&mp->m_perag_lock);
> + found = radix_tree_gang_lookup_tag(&mp->m_perag_tree,
> + (void **)&pag, *first, 1, tag);
> + if (found <= 0) {
> + spin_unlock(&mp->m_perag_lock);
> + return NULL;
> + }
> + *first = pag->pag_agno + 1;
> + /* open coded pag reference increment */
> + ref = atomic_inc_return(&pag->pag_ref);
> + spin_unlock(&mp->m_perag_lock);
> + trace_xfs_perag_get_reclaim(mp, pag->pag_agno, ref, _RET_IP_);
> + } else {
> + pag = xfs_perag_get(mp, *first);
> + (*first)++;
> + }
I wonder if we should just split the AG iterator for inode reclaim vs
the rest. We now have this difference in addition to taking the per-AG
lock exclusive instead of shared.
Anyway, the patch looks good for now,
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 3/3] xfs: track AGs with reclaimable inodes in per-ag radix tree
Date: Thu, 15 Jul 2010 14:12:28 -0400 [thread overview]
Message-ID: <20100715181228.GC14554@infradead.org> (raw)
In-Reply-To: <1279194418-16119-4-git-send-email-david@fromorbit.com>
> + */
> +static struct xfs_perag *
> +xfs_inode_ag_iter_next_pag(
> + struct xfs_mount *mp,
> + xfs_agnumber_t *first,
> + int tag)
> +{
> + struct xfs_perag *pag = NULL;
> +
> + if (tag == XFS_ICI_RECLAIM_TAG) {
> + int found;
> + int ref;
> +
> + spin_lock(&mp->m_perag_lock);
> + found = radix_tree_gang_lookup_tag(&mp->m_perag_tree,
> + (void **)&pag, *first, 1, tag);
> + if (found <= 0) {
> + spin_unlock(&mp->m_perag_lock);
> + return NULL;
> + }
> + *first = pag->pag_agno + 1;
> + /* open coded pag reference increment */
> + ref = atomic_inc_return(&pag->pag_ref);
> + spin_unlock(&mp->m_perag_lock);
> + trace_xfs_perag_get_reclaim(mp, pag->pag_agno, ref, _RET_IP_);
> + } else {
> + pag = xfs_perag_get(mp, *first);
> + (*first)++;
> + }
I wonder if we should just split the AG iterator for inode reclaim vs
the rest. We now have this difference in addition to taking the per-AG
lock exclusive instead of shared.
Anyway, the patch looks good for now,
Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-07-15 18:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 11:46 [PATCH 0/3] shrinker fixes for XFS for 2.6.35 Dave Chinner
2010-07-15 11:46 ` Dave Chinner
2010-07-15 11:46 ` Dave Chinner
2010-07-15 11:46 ` [PATCH 1/3] mm: add context argument to shrinker callback Dave Chinner
2010-07-15 11:46 ` Dave Chinner
2010-07-15 11:46 ` Dave Chinner
2010-07-15 18:09 ` Christoph Hellwig
2010-07-15 18:09 ` Christoph Hellwig
2010-07-15 18:09 ` Christoph Hellwig
2010-07-20 19:30 ` Alex Elder
2010-07-20 19:30 ` Alex Elder
2010-07-20 19:30 ` Alex Elder
2010-07-20 22:53 ` Dave Chinner
2010-07-20 22:53 ` Dave Chinner
2010-07-20 22:53 ` Dave Chinner
2010-07-15 11:46 ` [PATCH 2/3] xfs: convert inode shrinker to per-filesystem contexts Dave Chinner
2010-07-15 11:46 ` Dave Chinner
2010-07-15 11:46 ` Dave Chinner
2010-07-15 18:10 ` Christoph Hellwig
2010-07-15 18:10 ` Christoph Hellwig
2010-07-15 18:10 ` Christoph Hellwig
2010-07-20 19:30 ` Alex Elder
2010-07-20 19:30 ` Alex Elder
2010-07-20 19:30 ` Alex Elder
2010-07-15 11:46 ` [PATCH 3/3] xfs: track AGs with reclaimable inodes in per-ag radix tree Dave Chinner
2010-07-15 11:46 ` Dave Chinner
2010-07-15 11:46 ` Dave Chinner
2010-07-15 18:12 ` Christoph Hellwig [this message]
2010-07-15 18:12 ` Christoph Hellwig
2010-07-15 18:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100715181228.GC14554@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.