From: Christoph Hellwig <hch@infradead.org>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Dave Chinner <dchinner@redhat.com>,
Felix Blyakher <felixb@sgi.com>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
xfs-masters@oss.sgi.com, Alex Elder <aelder@sgi.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 6/8] xfs: fix unsigned underflow
Date: Thu, 15 Jul 2010 21:21:16 +0000 [thread overview]
Message-ID: <20100715212116.GA7013@infradead.org> (raw)
In-Reply-To: <1279219605-12631-1-git-send-email-segooon@gmail.com>
On Thu, Jul 15, 2010 at 10:46:45PM +0400, Kulikov Vasiliy wrote:
> map_len is unsigned. Checking map_len <= 0 is buggy when it should be
> below zero. So, check exact expression instead of map_len.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Dave Chinner <dchinner@redhat.com>,
Felix Blyakher <felixb@sgi.com>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
xfs-masters@oss.sgi.com, Alex Elder <aelder@sgi.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 6/8] xfs: fix unsigned underflow
Date: Thu, 15 Jul 2010 17:21:16 -0400 [thread overview]
Message-ID: <20100715212116.GA7013@infradead.org> (raw)
In-Reply-To: <1279219605-12631-1-git-send-email-segooon@gmail.com>
On Thu, Jul 15, 2010 at 10:46:45PM +0400, Kulikov Vasiliy wrote:
> map_len is unsigned. Checking map_len <= 0 is buggy when it should be
> below zero. So, check exact expression instead of map_len.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org, Alex Elder <aelder@sgi.com>,
Felix Blyakher <felixb@sgi.com>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
xfs-masters@oss.sgi.com, Dave Chinner <dchinner@redhat.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 6/8] xfs: fix unsigned underflow
Date: Thu, 15 Jul 2010 17:21:16 -0400 [thread overview]
Message-ID: <20100715212116.GA7013@infradead.org> (raw)
In-Reply-To: <1279219605-12631-1-git-send-email-segooon@gmail.com>
On Thu, Jul 15, 2010 at 10:46:45PM +0400, Kulikov Vasiliy wrote:
> map_len is unsigned. Checking map_len <= 0 is buggy when it should be
> below zero. So, check exact expression instead of map_len.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2010-07-15 21:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 18:46 [PATCH 6/8] xfs: fix unsigned underflow Kulikov Vasiliy
2010-07-15 18:46 ` Kulikov Vasiliy
2010-07-15 18:46 ` Kulikov Vasiliy
2010-07-15 21:21 ` Christoph Hellwig [this message]
2010-07-15 21:21 ` Christoph Hellwig
2010-07-15 21:21 ` Christoph Hellwig
2010-07-20 19:35 ` Alex Elder
2010-07-20 19:35 ` Alex Elder
2010-07-20 19:35 ` Alex Elder
2010-07-20 20:21 ` Vasiliy Kulikov
2010-07-20 20:21 ` Vasiliy Kulikov
2010-07-20 20:21 ` Vasiliy Kulikov
2010-07-20 23:12 ` Dave Chinner
2010-07-20 23:12 ` Dave Chinner
2010-07-20 23:12 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100715212116.GA7013@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=dchinner@redhat.com \
--cc=felixb@sgi.com \
--cc=hch@lst.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segooon@gmail.com \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.