From: Greg KH <gregkh@suse.de>
To: Joe Perches <joe@perches.com>
Cc: Peter Huewe <PeterHuewe@gmx.de>,
Kernel Janitors <kernel-janitors@vger.kernel.org>,
"Digi International, Inc" <Eng.Linux@digi.com>,
Alexey Dobriyan <adobriyan@gmail.com>, Tejun Heo <tj@kernel.org>,
Jiri Kosina <jkosina@suse.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE
Date: Fri, 16 Jul 2010 04:29:43 +0000 [thread overview]
Message-ID: <20100716042943.GB28607@suse.de> (raw)
In-Reply-To: <1279227615.5816.96.camel@Joe-Laptop.home>
On Thu, Jul 15, 2010 at 02:00:15PM -0700, Joe Perches wrote:
> On Thu, 2010-07-15 at 13:45 -0700, Greg KH wrote:
> > I much prefer the PCI_DEVICE() macro instead, and as such, I'm not
> > willing to take any of these patches, sorry.
>
> grepping for pci device ids using constants and
> expecting the result to be comprehensive isn't
> sensible.
But it's a nice goal :)
> $ grep -rwP --include=*.[ch] -w PCI_VDEVICE drivers/char | wc -l
> 32
drivers/char is not exactly a large collection of PCI drivers, only some
old serial port ones.
> The current drivers/ use of PCI_VDEVICE to PCI_DEVICE is ~50/50
>
> $ grep --include=*.[ch] -rwP PCI_DEVICE drivers | wc -l
> 866
> $ grep --include=*.[ch] -rwP PCI_VDEVICE drivers | wc -l
> 768
Hey, anything to increase that ratio is good :)
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@suse.de>
To: Joe Perches <joe@perches.com>
Cc: Peter Huewe <PeterHuewe@gmx.de>,
Kernel Janitors <kernel-janitors@vger.kernel.org>,
"Digi International, Inc" <Eng.Linux@digi.com>,
Alexey Dobriyan <adobriyan@gmail.com>, Tejun Heo <tj@kernel.org>,
Jiri Kosina <jkosina@suse.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
Date: Thu, 15 Jul 2010 21:29:43 -0700 [thread overview]
Message-ID: <20100716042943.GB28607@suse.de> (raw)
In-Reply-To: <1279227615.5816.96.camel@Joe-Laptop.home>
On Thu, Jul 15, 2010 at 02:00:15PM -0700, Joe Perches wrote:
> On Thu, 2010-07-15 at 13:45 -0700, Greg KH wrote:
> > I much prefer the PCI_DEVICE() macro instead, and as such, I'm not
> > willing to take any of these patches, sorry.
>
> grepping for pci device ids using constants and
> expecting the result to be comprehensive isn't
> sensible.
But it's a nice goal :)
> $ grep -rwP --include=*.[ch] -w PCI_VDEVICE drivers/char | wc -l
> 32
drivers/char is not exactly a large collection of PCI drivers, only some
old serial port ones.
> The current drivers/ use of PCI_VDEVICE to PCI_DEVICE is ~50/50
>
> $ grep --include=*.[ch] -rwP PCI_DEVICE drivers | wc -l
> 866
> $ grep --include=*.[ch] -rwP PCI_VDEVICE drivers | wc -l
> 768
Hey, anything to increase that ratio is good :)
thanks,
greg k-h
next prev parent reply other threads:[~2010-07-16 4:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 18:52 [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Peter Huewe
2010-07-15 18:52 ` Peter Huewe
2010-07-15 20:45 ` [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE Greg KH
2010-07-15 20:45 ` [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Greg KH
2010-07-15 21:00 ` [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE Joe Perches
2010-07-15 21:00 ` [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Joe Perches
2010-07-16 4:29 ` Greg KH [this message]
2010-07-16 4:29 ` Greg KH
2010-07-16 4:44 ` [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE Joe Perches
2010-07-16 4:44 ` [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Joe Perches
2010-07-16 5:29 ` [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE Greg KH
2010-07-16 5:29 ` [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Greg KH
2010-07-16 5:37 ` [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE Joe Perches
2010-07-16 5:37 ` [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Joe Perches
2010-07-16 5:47 ` [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE Greg KH
2010-07-16 5:47 ` [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Greg KH
2010-07-15 21:07 ` Peter Hüwe
2010-07-15 21:07 ` Peter Hüwe
2010-07-16 4:28 ` [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE Greg KH
2010-07-16 4:28 ` [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Greg KH
2010-07-16 23:54 ` Peter Hüwe
2010-07-16 23:54 ` Peter Hüwe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100716042943.GB28607@suse.de \
--to=gregkh@suse.de \
--cc=Eng.Linux@digi.com \
--cc=PeterHuewe@gmx.de \
--cc=adobriyan@gmail.com \
--cc=jkosina@suse.cz \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.