From: gregkh@suse.de (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: tq 2440
Date: Fri, 16 Jul 2010 01:55:33 -0700 [thread overview]
Message-ID: <20100716085533.GB2419@suse.de> (raw)
In-Reply-To: <20100715210936.GB6773@n2100.arm.linux.org.uk>
On Thu, Jul 15, 2010 at 10:09:36PM +0100, Russell King - ARM Linux wrote:
> On Thu, Jul 15, 2010 at 01:51:53PM -0700, Greg KH wrote:
> > On Thu, Jul 15, 2010 at 06:33:22PM +0100, Russell King - ARM Linux wrote:
> > > Another way to avoid the other complaints is to remove
> > > the unregistration in platform_register_devices().
> >
> > No, because you could have created a platform device with a call to
> > platform_device_alloc() and then called platform_device_register() and
> > then later, platform_device_unregister(), right?
>
> No. Sorry, platform_register_devices should've been platform_add_devices().
> Please look at that function.
Hm, it just calls platform_device_register(), so it's pretty hard to
determine that it's a static device from that function.
> It's used to register an array of static platform devices from architecture
> code, as I've said in this thread once already.
I can't think of an easy way to prevent these types of devices from
being removed, other than the existing warnings we have. I'll mull it
over some more and see if I can come up with something in the future.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@suse.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Conke Hu <conke.hu@gmail.com>, CoffBeta <coffbeta@gmail.com>,
David Brownell <dbrownell@users.sourceforge.net>,
inux kernel <linux-kernel@vger.kernel.org>,
ext-jani.1.nikula@nokia.com,
Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: tq 2440
Date: Fri, 16 Jul 2010 01:55:33 -0700 [thread overview]
Message-ID: <20100716085533.GB2419@suse.de> (raw)
In-Reply-To: <20100715210936.GB6773@n2100.arm.linux.org.uk>
On Thu, Jul 15, 2010 at 10:09:36PM +0100, Russell King - ARM Linux wrote:
> On Thu, Jul 15, 2010 at 01:51:53PM -0700, Greg KH wrote:
> > On Thu, Jul 15, 2010 at 06:33:22PM +0100, Russell King - ARM Linux wrote:
> > > Another way to avoid the other complaints is to remove
> > > the unregistration in platform_register_devices().
> >
> > No, because you could have created a platform device with a call to
> > platform_device_alloc() and then called platform_device_register() and
> > then later, platform_device_unregister(), right?
>
> No. Sorry, platform_register_devices should've been platform_add_devices().
> Please look at that function.
Hm, it just calls platform_device_register(), so it's pretty hard to
determine that it's a static device from that function.
> It's used to register an array of static platform devices from architecture
> code, as I've said in this thread once already.
I can't think of an easy way to prevent these types of devices from
being removed, other than the existing warnings we have. I'll mull it
over some more and see if I can come up with something in the future.
thanks,
greg k-h
next prev parent reply other threads:[~2010-07-16 8:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 2:31 tq 2440 CoffBeta
2010-07-01 2:31 ` CoffBeta
2010-07-15 15:16 ` Conke Hu
2010-07-15 15:16 ` Conke Hu
2010-07-15 16:35 ` Russell King - ARM Linux
2010-07-15 16:35 ` Russell King - ARM Linux
2010-07-15 16:51 ` Greg KH
2010-07-15 16:51 ` Greg KH
2010-07-15 17:10 ` Russell King - ARM Linux
2010-07-15 17:10 ` Russell King - ARM Linux
2010-07-15 17:22 ` Greg KH
2010-07-15 17:22 ` Greg KH
2010-07-15 17:33 ` Russell King - ARM Linux
2010-07-15 17:33 ` Russell King - ARM Linux
2010-07-15 20:51 ` Greg KH
2010-07-15 20:51 ` Greg KH
2010-07-15 21:09 ` Russell King - ARM Linux
2010-07-15 21:09 ` Russell King - ARM Linux
2010-07-16 8:55 ` Greg KH [this message]
2010-07-16 8:55 ` Greg KH
2010-07-16 9:07 ` Russell King - ARM Linux
2010-07-16 9:07 ` Russell King - ARM Linux
2010-07-16 5:40 ` Conke Hu
2010-07-16 5:40 ` Conke Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100716085533.GB2419@suse.de \
--to=gregkh@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.