From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM/nuc900: fix nuc900 touchscreen clk definition bug
Date: Fri, 16 Jul 2010 09:19:24 +0200 [thread overview]
Message-ID: <201007160919.24927.marek.vasut@gmail.com> (raw)
In-Reply-To: <AANLkTinEqScq2E0MSRJrUN5fR-1rs8fB9rLgMdhYW9R6@mail.gmail.com>
Dne P? 16. ?ervence 2010 07:34:21 Wan ZongShun napsal(a):
> 2010/7/16 Marek Vasut <marek.vasut@gmail.com>:
> > Dne P? 16. ?ervence 2010 05:03:27 Wan ZongShun napsal(a):
> >> This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's
> >> name should be 'nuc900-ts', it should be the same to pdev.name. or else,
> >> the touchscreen driver will be not working well due to clock engine
> >> disabled.
> >>
> >> Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
> >> ---
> >> arch/arm/mach-w90x900/cpu.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/arch/arm/mach-w90x900/cpu.c b/arch/arm/mach-w90x900/cpu.c
> >> index 642207e..83c5632 100644
> >> --- a/arch/arm/mach-w90x900/cpu.c
> >> +++ b/arch/arm/mach-w90x900/cpu.c
> >> @@ -93,7 +93,7 @@ static struct clk_lookup nuc900_clkregs[] = {
> >> DEF_CLKLOOK(&clk_kpi, "nuc900-kpi", NULL),
> >> DEF_CLKLOOK(&clk_wdt, "nuc900-wdt", NULL),
> >> DEF_CLKLOOK(&clk_gdma, "nuc900-gdma", NULL),
> >> - DEF_CLKLOOK(&clk_adc, "nuc900-adc", NULL),
> >> + DEF_CLKLOOK(&clk_adc, "nuc900-ts", NULL),
> >> DEF_CLKLOOK(&clk_usi, "nuc900-spi", NULL),
> >> DEF_CLKLOOK(&clk_ext, NULL, "ext"),
> >> DEF_CLKLOOK(&clk_timer0, NULL, "timer0"),
> >
> > Hey,
> >
> > Is that thing really touchscreen or general-purpose analog/digital
> > converter ?
>
> Oh, it is general-purpose analog/digital converter controller.
> I only use it to implemnt my touchscreen function, Also it can be use
> other function.
>
> so, I have to change my touchscreen driver name to nuc900-adc?
No, just change the name of clock in the touchscreen driver. So that the
touchscreen driver will use nuc900-adc clocksource.
You're welcome. :)
>
> Thanks for your Reminder, I appreciate it. :)
>
> > Cheers
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marek.vasut@gmail.com>
To: Wan ZongShun <mcuos.com@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH] ARM/nuc900: fix nuc900 touchscreen clk definition bug
Date: Fri, 16 Jul 2010 09:19:24 +0200 [thread overview]
Message-ID: <201007160919.24927.marek.vasut@gmail.com> (raw)
In-Reply-To: <AANLkTinEqScq2E0MSRJrUN5fR-1rs8fB9rLgMdhYW9R6@mail.gmail.com>
Dne Pá 16. července 2010 07:34:21 Wan ZongShun napsal(a):
> 2010/7/16 Marek Vasut <marek.vasut@gmail.com>:
> > Dne Pá 16. července 2010 05:03:27 Wan ZongShun napsal(a):
> >> This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's
> >> name should be 'nuc900-ts', it should be the same to pdev.name. or else,
> >> the touchscreen driver will be not working well due to clock engine
> >> disabled.
> >>
> >> Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
> >> ---
> >> arch/arm/mach-w90x900/cpu.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/arch/arm/mach-w90x900/cpu.c b/arch/arm/mach-w90x900/cpu.c
> >> index 642207e..83c5632 100644
> >> --- a/arch/arm/mach-w90x900/cpu.c
> >> +++ b/arch/arm/mach-w90x900/cpu.c
> >> @@ -93,7 +93,7 @@ static struct clk_lookup nuc900_clkregs[] = {
> >> DEF_CLKLOOK(&clk_kpi, "nuc900-kpi", NULL),
> >> DEF_CLKLOOK(&clk_wdt, "nuc900-wdt", NULL),
> >> DEF_CLKLOOK(&clk_gdma, "nuc900-gdma", NULL),
> >> - DEF_CLKLOOK(&clk_adc, "nuc900-adc", NULL),
> >> + DEF_CLKLOOK(&clk_adc, "nuc900-ts", NULL),
> >> DEF_CLKLOOK(&clk_usi, "nuc900-spi", NULL),
> >> DEF_CLKLOOK(&clk_ext, NULL, "ext"),
> >> DEF_CLKLOOK(&clk_timer0, NULL, "timer0"),
> >
> > Hey,
> >
> > Is that thing really touchscreen or general-purpose analog/digital
> > converter ?
>
> Oh, it is general-purpose analog/digital converter controller.
> I only use it to implemnt my touchscreen function, Also it can be use
> other function.
>
> so, I have to change my touchscreen driver name to nuc900-adc?
No, just change the name of clock in the touchscreen driver. So that the
touchscreen driver will use nuc900-adc clocksource.
You're welcome. :)
>
> Thanks for your Reminder, I appreciate it. :)
>
> > Cheers
next prev parent reply other threads:[~2010-07-16 7:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 3:03 [PATCH] ARM/nuc900: fix nuc900 touchscreen clk definition bug Wan ZongShun
2010-07-16 3:03 ` Wan ZongShun
2010-07-16 5:09 ` Marek Vasut
2010-07-16 5:09 ` Marek Vasut
2010-07-16 5:34 ` Wan ZongShun
2010-07-16 5:34 ` Wan ZongShun
2010-07-16 7:19 ` Marek Vasut [this message]
2010-07-16 7:19 ` Marek Vasut
2010-07-16 9:11 ` Wan ZongShun
2010-07-16 9:11 ` Wan ZongShun
2010-07-18 9:00 ` Russell King - ARM Linux
2010-07-18 9:00 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007160919.24927.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.