From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: Kernel Janitors <kernel-janitors@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 05/19] arch/x86/kernel: use for_each_pci_dev()
Date: Mon, 19 Jul 2010 13:42:18 +0000 [thread overview]
Message-ID: <20100719134218.GC7454@amd.com> (raw)
In-Reply-To: <1278173032-11575-1-git-send-email-segooon@gmail.com>
On Sat, Jul 03, 2010 at 12:03:51PM -0400, Kulikov Vasiliy wrote:
> Use for_each_pci_dev() to simplify the code.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
> arch/x86/kernel/amd_iommu.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
> index 0d20286..29dd3b9 100644
> --- a/arch/x86/kernel/amd_iommu.c
> +++ b/arch/x86/kernel/amd_iommu.c
> @@ -2609,8 +2609,7 @@ int __init amd_iommu_init_passthrough(void)
>
> pt_domain->mode |= PAGE_MODE_NONE;
>
> - while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
> -
> + for_each_pci_dev(dev) {
> if (!check_device(&dev->dev))
> continue;
Applied, thanks.
--
Joerg Roedel - AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
WARNING: multiple messages have this Message-ID (diff)
From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: Kernel Janitors <kernel-janitors@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 05/19] arch/x86/kernel: use for_each_pci_dev()
Date: Mon, 19 Jul 2010 15:42:18 +0200 [thread overview]
Message-ID: <20100719134218.GC7454@amd.com> (raw)
In-Reply-To: <1278173032-11575-1-git-send-email-segooon@gmail.com>
On Sat, Jul 03, 2010 at 12:03:51PM -0400, Kulikov Vasiliy wrote:
> Use for_each_pci_dev() to simplify the code.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
> arch/x86/kernel/amd_iommu.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
> index 0d20286..29dd3b9 100644
> --- a/arch/x86/kernel/amd_iommu.c
> +++ b/arch/x86/kernel/amd_iommu.c
> @@ -2609,8 +2609,7 @@ int __init amd_iommu_init_passthrough(void)
>
> pt_domain->mode |= PAGE_MODE_NONE;
>
> - while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
> -
> + for_each_pci_dev(dev) {
> if (!check_device(&dev->dev))
> continue;
Applied, thanks.
--
Joerg Roedel - AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2010-07-19 13:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-03 16:03 [PATCH 05/19] arch/x86/kernel: use for_each_pci_dev() Kulikov Vasiliy
2010-07-03 16:03 ` Kulikov Vasiliy
2010-07-19 13:42 ` Roedel, Joerg [this message]
2010-07-19 13:42 ` Roedel, Joerg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100719134218.GC7454@amd.com \
--to=joerg.roedel@amd.com \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=segooon@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.