All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Dan Kruchinin <dkruchinin@acm.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/4] padata/pcrypt: fixes
Date: Tue, 20 Jul 2010 08:47:36 +0200	[thread overview]
Message-ID: <20100720064736.GB11081@secunet.com> (raw)
In-Reply-To: <20100719073255.GA20403@gondor.apana.org.au>

This patchset contains the following fixes:

1. padata - Fix a potential hang of the parallel worker threads on
cpu hotplug.

2. padata - Fix two NULL pointer dereference crashes if one of the
padata cpumasks is empty. The crashes can be triggered by doing
echo 0 > /sys/kernel/pcrypt/pencrypt/[parallel_cpumask/serial_cpumask]

3. padata - Fix a division by zero crash if the parallel cpumask
contains no active cpu. Can be triggered by doing
echo 0 > /sys/kernel/pcrypt/pencrypt/parallel_cpumask

4. pcrypt - Fix division by zero crash if the callback cpumask
is empty. Can be triggered by doing
echo 0 > /sys/kernel/pcrypt/pencrypt/serial_cpumask

I ran a script that does cpumask changes and cpu hotplugs as fast as
possible while sending IPsec packets on maximal rate with pcrypt.
It showed no furter crashes overnight, so I hope I've got them all.

padata API corrections and some minor fixes/cleanups are comming later.

Steffen

WARNING: multiple messages have this Message-ID (diff)
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: Dan Kruchinin <dkruchinin@acm.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/4] padata/pcrypt: fixes
Date: Tue, 20 Jul 2010 08:47:36 +0200	[thread overview]
Message-ID: <20100720064736.GB11081@secunet.com> (raw)
In-Reply-To: <20100719073255.GA20403@gondor.apana.org.au>

This patchset contains the following fixes:

1. padata - Fix a potential hang of the parallel worker threads on
cpu hotplug.

2. padata - Fix two NULL pointer dereference crashes if one of the
padata cpumasks is empty. The crashes can be triggered by doing
echo 0 > /sys/kernel/pcrypt/pencrypt/[parallel_cpumask/serial_cpumask]

3. padata - Fix a division by zero crash if the parallel cpumask
contains no active cpu. Can be triggered by doing
echo 0 > /sys/kernel/pcrypt/pencrypt/parallel_cpumask

4. pcrypt - Fix division by zero crash if the callback cpumask
is empty. Can be triggered by doing
echo 0 > /sys/kernel/pcrypt/pencrypt/serial_cpumask

I ran a script that does cpumask changes and cpu hotplugs as fast as
possible while sending IPsec packets on maximal rate with pcrypt.
It showed no furter crashes overnight, so I hope I've got them all.

padata API corrections and some minor fixes/cleanups are comming later.

Steffen

  reply	other threads:[~2010-07-20  6:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-14 10:29 [PATCH 0/3] padata: cpumasks Dan Kruchinin
2010-07-14 10:29 ` Dan Kruchinin
2010-07-19  6:04 ` Herbert Xu
2010-07-19  6:04   ` Herbert Xu
2010-07-19  6:40   ` Steffen Klassert
2010-07-19  6:40     ` Steffen Klassert
2010-07-19  7:32     ` Herbert Xu
2010-07-19  7:32       ` Herbert Xu
2010-07-20  6:47       ` Steffen Klassert [this message]
2010-07-20  6:47         ` [PATCH 0/4] padata/pcrypt: fixes Steffen Klassert
2010-07-20  6:48         ` [PATCH 1/4] padata: Fix cpu index counting Steffen Klassert
2010-07-20  6:48           ` Steffen Klassert
2010-07-20  6:49         ` [PATCH 2/4] padata: Allocate cpumask dependend recources in any case Steffen Klassert
2010-07-20  6:49           ` Steffen Klassert
2010-07-20  6:51         ` [PATCH 3/4] padata: Check for valid cpumasks Steffen Klassert
2010-07-20  6:51           ` Steffen Klassert
2010-07-20  6:52         ` [PATCH 4/4] crypto: pcrypt - Dont calulate a callback cpu on empty callback cpumask Steffen Klassert
2010-07-20  6:52           ` Steffen Klassert
2010-07-26  6:16         ` [PATCH 0/4] padata/pcrypt: fixes Herbert Xu
2010-07-26  6:16           ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100720064736.GB11081@secunet.com \
    --to=steffen.klassert@secunet.com \
    --cc=akpm@linux-foundation.org \
    --cc=dkruchinin@acm.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.