From: Colin Watson <cjwatson@ubuntu.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: 554790@bugs.debian.org, Vadim Solomin <vadic052@gmail.com>
Subject: Re: Bug#554790: This breaks device.map on upgrade
Date: Tue, 20 Jul 2010 17:16:43 +0100 [thread overview]
Message-ID: <20100720161643.GR21862@riva.ucam.org> (raw)
In-Reply-To: <4C459E77.3090908@gmail.com>
On Tue, Jul 20, 2010 at 03:02:47PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 07/12/2010 12:38 PM, Colin Watson wrote:
> >> Vladimir, would this patch need a copyright assignment? Most of it
> >> seems pretty straightforward; in fact I doubt that it would come out
> >> very much different if I'd written it from scratch.
>
> No need of copyright assignment for this patch.
>
> > 2010-07-12 Vadim Solomin <vadic052@gmail.com>
> > 2010-07-12 Colin Watson <cjwatson@ubuntu.com>
> >
> > Generate device.map in something closer to the old ordering.
> >
> > * util/deviceiter.c (struct device): New declaration.
> > (compare_file_names): Rename to ...
> > (compare_devices): ... this. Sort by kernel name in preference
> > to the stable by-id name, but keep the latter as a fallback
> > comparison. Update header comment.
> > (grub_util_iterate_devices) [__linux__]: Construct and sort an
> > array of `struct device' rather than of plain file names.
>
> Go ahead.
OK, committed. Thanks.
--
Colin Watson [cjwatson@ubuntu.com]
prev parent reply other threads:[~2010-07-20 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201007090801.12986.vadic052@gmail.com>
2010-07-11 23:26 ` Bug#554790: This breaks device.map on upgrade Colin Watson
2010-07-12 10:38 ` Colin Watson
2010-07-20 13:02 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-07-20 16:16 ` Colin Watson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100720161643.GR21862@riva.ucam.org \
--to=cjwatson@ubuntu.com \
--cc=554790@bugs.debian.org \
--cc=grub-devel@gnu.org \
--cc=vadic052@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.