All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Egger <Christoph.Egger@amd.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH] libxl: fix linking error
Date: Thu, 22 Jul 2010 10:28:30 +0200	[thread overview]
Message-ID: <201007221028.31235.Christoph.Egger@amd.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1007211713581.22235@kaball-desktop>

On Wednesday 21 July 2010 18:14:14 Stefano Stabellini wrote:
> On Wed, 21 Jul 2010, Ian Jackson wrote:
> > Christoph Egger writes ("[Xen-devel] [PATCH] libxl: fix linking error"):
> > > Attached patch fixes linking error when creating the xl binary.
> > > The xl binary compiles in xl_cmdimpl.c which calls code from
> > > libxl_paths.c and libxl_bootloader.c.
> >
> > ...
> >
> > > -$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxlutil.so
> > > libxenlight.so +$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o
> > > libxl_paths.o libxl_bootloader.o libxlutil.so libxenlight.so
> >
> > This can't possibly be right.  Files called "libxl_*.o" are parts of
> > libxl and should be in libxenlight.so.
> >
> > I see, however, that Stefano has already applied it.
>
> Yes, sorry I missed it.

I realized this patch is wrong. Please apply the patch to correct this:
http://lists.xensource.com/archives/html/xen-devel/2010-07/msg01068.html

Christoph

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

      reply	other threads:[~2010-07-22  8:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-20 16:24 [PATCH] libxl: fix linking error Christoph Egger
2010-07-21 15:56 ` Ian Jackson
2010-07-21 16:14   ` Stefano Stabellini
2010-07-22  8:28     ` Christoph Egger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201007221028.31235.Christoph.Egger@amd.com \
    --to=christoph.egger@amd.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.