* [patch -next] caif: precedence bug
@ 2010-07-22 11:11 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-07-22 11:11 UTC (permalink / raw)
To: SjurBraendeland
Cc: David S. Miller, Sjur Braendeland, netdev, kernel-janitors
Negate has precedence over comparison so the original assert only
checked that "rfml->fragment_size" was larger than 1 or 0.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/net/caif/cfrfml.c b/net/caif/cfrfml.c
index 4b04d25..eb16020 100644
--- a/net/caif/cfrfml.c
+++ b/net/caif/cfrfml.c
@@ -193,7 +193,7 @@ out:
static int cfrfml_transmit_segment(struct cfrfml *rfml, struct cfpkt *pkt)
{
- caif_assert(!cfpkt_getlen(pkt) < rfml->fragment_size);
+ caif_assert(cfpkt_getlen(pkt) >= rfml->fragment_size);
/* Add info for MUX-layer to route the packet out. */
cfpkt_info(pkt)->channel_id = rfml->serv.layer.id;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch -next] caif: precedence bug
@ 2010-07-22 11:11 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-07-22 11:11 UTC (permalink / raw)
To: SjurBraendeland
Cc: David S. Miller, Sjur Braendeland, netdev, kernel-janitors
Negate has precedence over comparison so the original assert only
checked that "rfml->fragment_size" was larger than 1 or 0.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/net/caif/cfrfml.c b/net/caif/cfrfml.c
index 4b04d25..eb16020 100644
--- a/net/caif/cfrfml.c
+++ b/net/caif/cfrfml.c
@@ -193,7 +193,7 @@ out:
static int cfrfml_transmit_segment(struct cfrfml *rfml, struct cfpkt *pkt)
{
- caif_assert(!cfpkt_getlen(pkt) < rfml->fragment_size);
+ caif_assert(cfpkt_getlen(pkt) >= rfml->fragment_size);
/* Add info for MUX-layer to route the packet out. */
cfpkt_info(pkt)->channel_id = rfml->serv.layer.id;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch -next] caif: precedence bug
2010-07-22 11:11 ` Dan Carpenter
@ 2010-07-22 21:13 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-07-22 21:13 UTC (permalink / raw)
To: error27; +Cc: SjurBraendeland, sjur.brandeland, netdev, kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Thu, 22 Jul 2010 13:11:31 +0200
> Negate has precedence over comparison so the original assert only
> checked that "rfml->fragment_size" was larger than 1 or 0.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch -next] caif: precedence bug
@ 2010-07-22 21:13 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-07-22 21:13 UTC (permalink / raw)
To: error27; +Cc: SjurBraendeland, sjur.brandeland, netdev, kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Thu, 22 Jul 2010 13:11:31 +0200
> Negate has precedence over comparison so the original assert only
> checked that "rfml->fragment_size" was larger than 1 or 0.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-22 21:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-22 11:11 [patch -next] caif: precedence bug Dan Carpenter
2010-07-22 11:11 ` Dan Carpenter
2010-07-22 21:13 ` David Miller
2010-07-22 21:13 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.