[Qemu-devel] Re: [PATCH v4 0/3] QMP: Introduce query-available-devices (was query-qdm)

[Luiz Capitulino <lcapitulino@redhat.com>]

On Fri, 23 Jul 2010 13:47:37 -0300
Miguel Di Ciurcio Filho <miguel.filho@gmail.com> wrote:

> This series introduces the documentation for the query-available-devices command
> and the conversion of the monitor command 'info qdm' to QMP.
> 
> The documentation and code were based on a patch previously sent to qemu-devel
> by Daniel P. Berrange:
> 
> http://lists.gnu.org/archive/html/qemu-devel/2010-06/msg00931.html

Looks good to me now, pushed it to the monitor queue.

Only detail is that query-qdm was available and there was some unneeded
blank lines, fixed both.

> 
> Changelog from v3
> -----------------
> - Renamed the command from query-qdm to query-available-devices
> - Fixed coding style when declaring the variable 'type'
> - Fixed qlist leak in case the device does not have any property
> - Split the series from 2 to 3 parts for easier review
> 
> Changelog from v2
> -----------------
> - added IDE and s390-virtio as possible values for "bus"
> - specify that the "properties" list is optional, in case the device doesn't
> have anything to be setup
> - reworded the explanation of "creatable"
> - reverted the qdev/qmp split, just use "type" and its json equivalent
> representation
> - do not list legacy stuff: PROP_TYPE_(VLAN|PTR|UNSPEC)
> 
> Changelog from v1
> -----------------
> - renamed "props" to "properties"
> - updated the examples
> - reworded the explanations of "name" and "description"
> - split "type" into a json-object, adding "qmp" and "qdev"
> - list all possible values for "bus"
> - list all possible values for "qdev" on "type"
> - list all possible values for "qmp" on "type"
> 
> Changes from the Daniel's original patch:
> - Split the patch in two, taking out the documentation from the code
> - Reworded some parts of the documentation and added data types
> - Small cleanups and renamed do_info_devices() to do_info_qdm()
> - Added do_info_qdm_print() to be used in the monitor
> 
> Regards,
> 
> Miguel
> 
> ---
> 
> *** BLURB HERE ***
> 
> Miguel Di Ciurcio Filho (3):
>   QMP: Introduce the documentation for query-available-devices
>   QMP: Introduce query-available-devices
>   monitor: Convert 'info qdm' to QMP
> 
>  hw/qdev.c       |  111 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  hw/qdev.h       |    3 +-
>  monitor.c       |   11 +++++-
>  qemu-monitor.hx |   71 +++++++++++++++++++++++++++++++++++
>  4 files changed, 192 insertions(+), 4 deletions(-)
>