From: "Gustavo F. Padovan" <gustavo@padovan.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Suraj Sumangala <suraj@atheros.com>,
linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] bluetooth/hci_ath: kfree() => kfree_skb()
Date: Fri, 23 Jul 2010 18:10:53 +0000 [thread overview]
Message-ID: <20100723181053.GN2620@vigoh> (raw)
In-Reply-To: <20100723101104.GD26313@bicker>
Hi Dan,
* Dan Carpenter <error27@gmail.com> [2010-07-23 12:11:04 +0200]:
> sk_buffs have to be freed with kfree_skb() instead of kfree().
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/bluetooth/hci_ath.c b/drivers/bluetooth/hci_ath.c
> index 5ab258b..74a8f61 100755
> --- a/drivers/bluetooth/hci_ath.c
> +++ b/drivers/bluetooth/hci_ath.c
> @@ -163,7 +163,7 @@ static int ath_enqueue(struct hci_uart *hu, struct sk_buff *skb)
> struct ath_struct *ath = hu->priv;
>
> if (bt_cb(skb)->pkt_type = HCI_SCODATA_PKT) {
> - kfree(skb);
> + kfree_skb(skb);
> return 0;
> }
Acked-by: Gustavo F. Padovan <padovan@profusion.mobi>
--
Gustavo F. Padovan
http://padovan.org
WARNING: multiple messages have this Message-ID (diff)
From: "Gustavo F. Padovan" <gustavo@padovan.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Suraj Sumangala <suraj@atheros.com>,
linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] bluetooth/hci_ath: kfree() => kfree_skb()
Date: Fri, 23 Jul 2010 15:10:53 -0300 [thread overview]
Message-ID: <20100723181053.GN2620@vigoh> (raw)
In-Reply-To: <20100723101104.GD26313@bicker>
Hi Dan,
* Dan Carpenter <error27@gmail.com> [2010-07-23 12:11:04 +0200]:
> sk_buffs have to be freed with kfree_skb() instead of kfree().
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/bluetooth/hci_ath.c b/drivers/bluetooth/hci_ath.c
> index 5ab258b..74a8f61 100755
> --- a/drivers/bluetooth/hci_ath.c
> +++ b/drivers/bluetooth/hci_ath.c
> @@ -163,7 +163,7 @@ static int ath_enqueue(struct hci_uart *hu, struct sk_buff *skb)
> struct ath_struct *ath = hu->priv;
>
> if (bt_cb(skb)->pkt_type == HCI_SCODATA_PKT) {
> - kfree(skb);
> + kfree_skb(skb);
> return 0;
> }
Acked-by: Gustavo F. Padovan <padovan@profusion.mobi>
--
Gustavo F. Padovan
http://padovan.org
next prev parent reply other threads:[~2010-07-23 18:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 10:11 [patch -next] bluetooth/hci_ath: kfree() => kfree_skb() Dan Carpenter
2010-07-23 10:11 ` Dan Carpenter
2010-07-23 18:10 ` Gustavo F. Padovan [this message]
2010-07-23 18:10 ` Gustavo F. Padovan
2010-07-27 22:28 ` Marcel Holtmann
2010-07-27 22:28 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100723181053.GN2620@vigoh \
--to=gustavo@padovan.org \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=suraj@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.