From: Jonathan Nieder <jrnieder@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Thomas Rast <trast@student.ethz.ch>
Subject: Re: [PATCH v2 1/7] gitignore: Ignore files generated by "make coverage"
Date: Sun, 25 Jul 2010 11:37:42 -0500 [thread overview]
Message-ID: <20100725163742.GA25658@burratino> (raw)
In-Reply-To: <1280068861-17701-2-git-send-email-avarab@gmail.com>
Hi,
Ævar Arnfjörð Bjarmason wrote:
> Change gitignore to ignore the *.gcda, *.gcno and *.gcov files
> generated by GCC and our coverage invocations.
Good idea. The following is nitpicking of the worst kind; sorry.
It is easier to maintain frequently-changing lists like .gitignore
and the #include lines in source files if new additions go in some
logical place in the middle instead of the end. There is less
lock contention that way. :)
So maybe:
diff --git i/.gitignore w/.gitignore
index 0e61845..57f79ef 100644
--- i/.gitignore
+++ w/.gitignore
@@ -181,6 +181,10 @@
*.[aos]
*.py[co]
.depend/
+*.gcda
+*.gcno
+*.gcov
+/coverage-untested-functions
*+
/config.mak
/autom4te.cache
@@ -204,7 +208,3 @@
*.pdb
/Debug/
/Release/
-*.gcda
-*.gcno
-*.gcov
-/coverage-untested-functions
--
next prev parent reply other threads:[~2010-07-25 16:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-25 14:40 [PATCH v2 0/7] Detailed test coverage reports for Git Ævar Arnfjörð Bjarmason
2010-07-25 14:40 ` [PATCH v2 1/7] gitignore: Ignore files generated by "make coverage" Ævar Arnfjörð Bjarmason
2010-07-25 16:37 ` Jonathan Nieder [this message]
2010-07-25 14:40 ` [PATCH v2 2/7] Makefile: Include subdirectories in "make cover" reports Ævar Arnfjörð Bjarmason
2010-07-25 17:02 ` Jonathan Nieder
2010-07-25 14:40 ` [PATCH v2 3/7] Makefile: Split out the untested functions target Ævar Arnfjörð Bjarmason
2010-07-25 14:40 ` [PATCH v2 4/7] Makefile: Add coverage-report-cover-db target Ævar Arnfjörð Bjarmason
2010-07-25 17:13 ` Jonathan Nieder
2010-07-25 14:40 ` [PATCH v2 5/7] Makefile: Add coverage-report-cover-db-html target Ævar Arnfjörð Bjarmason
2010-07-25 17:17 ` Jonathan Nieder
2010-07-25 14:41 ` [PATCH v2 6/7] t/README: A new section about test coverage Ævar Arnfjörð Bjarmason
2010-07-25 14:41 ` [PATCH v2 7/7] t/README: Add a note about the dangers of coverage chasing Ævar Arnfjörð Bjarmason
2010-07-25 16:05 ` Jonathan Nieder
2010-07-25 19:27 ` Ævar Arnfjörð Bjarmason
2010-07-25 17:20 ` [PATCH v2 0/7] Detailed test coverage reports for Git Jonathan Nieder
2010-07-25 17:46 ` Ævar Arnfjörð Bjarmason
2010-07-25 17:48 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100725163742.GA25658@burratino \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.