From: Jonathan Nieder <jrnieder@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Thomas Rast <trast@student.ethz.ch>
Subject: Re: [PATCH v2 0/7] Detailed test coverage reports for Git
Date: Sun, 25 Jul 2010 12:48:32 -0500 [thread overview]
Message-ID: <20100725174832.GB9146@burratino> (raw)
In-Reply-To: <AANLkTikHXRJcuv35uFrv_g1umVdUM-QD80brFGj94E3N@mail.gmail.com>
Ævar Arnfjörð Bjarmason wrote:
> On Sun, Jul 25, 2010 at 17:20, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> Ævar Arnfjörð Bjarmason wrote:
>>> Ævar Arnfjörð Bjarmason (7):
>>> gitignore: Ignore files generated by "make coverage"
>>> Makefile: Include subdirectories in "make cover" reports
>>> Makefile: Split out the untested functions target
>>> Makefile: Add coverage-report-cover-db target
>>> Makefile: Add coverage-report-cover-db-html target
>>> t/README: A new section about test coverage
>>> t/README: Add a note about the dangers of coverage chasing
[...]
> All the changes you made look good, I approve of having them squashed
> when this is applied. Thanks.
I hope not. :) The change to coverage-clean suggested in my reply to
patch 4 needs at least a "-r" after the $(RM), since I had not noticed
that cover_db is a directory.
prev parent reply other threads:[~2010-07-25 17:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-25 14:40 [PATCH v2 0/7] Detailed test coverage reports for Git Ævar Arnfjörð Bjarmason
2010-07-25 14:40 ` [PATCH v2 1/7] gitignore: Ignore files generated by "make coverage" Ævar Arnfjörð Bjarmason
2010-07-25 16:37 ` Jonathan Nieder
2010-07-25 14:40 ` [PATCH v2 2/7] Makefile: Include subdirectories in "make cover" reports Ævar Arnfjörð Bjarmason
2010-07-25 17:02 ` Jonathan Nieder
2010-07-25 14:40 ` [PATCH v2 3/7] Makefile: Split out the untested functions target Ævar Arnfjörð Bjarmason
2010-07-25 14:40 ` [PATCH v2 4/7] Makefile: Add coverage-report-cover-db target Ævar Arnfjörð Bjarmason
2010-07-25 17:13 ` Jonathan Nieder
2010-07-25 14:40 ` [PATCH v2 5/7] Makefile: Add coverage-report-cover-db-html target Ævar Arnfjörð Bjarmason
2010-07-25 17:17 ` Jonathan Nieder
2010-07-25 14:41 ` [PATCH v2 6/7] t/README: A new section about test coverage Ævar Arnfjörð Bjarmason
2010-07-25 14:41 ` [PATCH v2 7/7] t/README: Add a note about the dangers of coverage chasing Ævar Arnfjörð Bjarmason
2010-07-25 16:05 ` Jonathan Nieder
2010-07-25 19:27 ` Ævar Arnfjörð Bjarmason
2010-07-25 17:20 ` [PATCH v2 0/7] Detailed test coverage reports for Git Jonathan Nieder
2010-07-25 17:46 ` Ævar Arnfjörð Bjarmason
2010-07-25 17:48 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100725174832.GB9146@burratino \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.