* [PATCH] cyber2000fb: fix machine hang on module load
@ 2010-07-25 16:52 ` Ondrej Zary
0 siblings, 0 replies; 2+ messages in thread
From: Ondrej Zary @ 2010-07-25 16:52 UTC (permalink / raw)
To: Russell King; +Cc: linux-fbdev, Kernel development list
Hello,
I was testing two CyberPro 2000 based PCI cards on x86 and the machine always
hanged completely when the cyber2000fb module was loaded. It seems that the
card hangs when some registers are accessed too quickly after writing RAMDAC
control register. With this patch, both card work.
Add delay after RAMDAC control register write to prevent hangs on module load.
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
--- linux-2.6.35-rc2/drivers/video/cyber2000fb.c 2010-06-06 05:43:24.000000000 +0200
+++ linux-2.6.35-rc3/drivers/video/cyber2000fb.c 2010-07-25 18:20:47.000000000 +0200
@@ -436,6 +436,7 @@ static void cyber2000fb_write_ramdac_ctr
cyber2000fb_writeb(i | 4, 0x3cf, cfb);
cyber2000fb_writeb(val, 0x3c6, cfb);
cyber2000fb_writeb(i, 0x3cf, cfb);
+ udelay(1);
}
static void cyber2000fb_set_timing(struct cfb_info *cfb, struct par_info *hw)
--
Ondrej Zary
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] cyber2000fb: fix machine hang on module load
@ 2010-07-25 16:52 ` Ondrej Zary
0 siblings, 0 replies; 2+ messages in thread
From: Ondrej Zary @ 2010-07-25 16:52 UTC (permalink / raw)
To: Russell King; +Cc: linux-fbdev, Kernel development list
Hello,
I was testing two CyberPro 2000 based PCI cards on x86 and the machine always
hanged completely when the cyber2000fb module was loaded. It seems that the
card hangs when some registers are accessed too quickly after writing RAMDAC
control register. With this patch, both card work.
Add delay after RAMDAC control register write to prevent hangs on module load.
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
--- linux-2.6.35-rc2/drivers/video/cyber2000fb.c 2010-06-06 05:43:24.000000000 +0200
+++ linux-2.6.35-rc3/drivers/video/cyber2000fb.c 2010-07-25 18:20:47.000000000 +0200
@@ -436,6 +436,7 @@ static void cyber2000fb_write_ramdac_ctr
cyber2000fb_writeb(i | 4, 0x3cf, cfb);
cyber2000fb_writeb(val, 0x3c6, cfb);
cyber2000fb_writeb(i, 0x3cf, cfb);
+ udelay(1);
}
static void cyber2000fb_set_timing(struct cfb_info *cfb, struct par_info *hw)
--
Ondrej Zary
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-25 16:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-25 16:52 [PATCH] cyber2000fb: fix machine hang on module load Ondrej Zary
2010-07-25 16:52 ` Ondrej Zary
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.