From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] dlm: use genl_register_family_with_ops()
Date: Mon, 26 Jul 2010 12:04:40 -0400 [thread overview]
Message-ID: <20100726160440.GA18604@redhat.com> (raw)
In-Reply-To: <1280135959-17485-1-git-send-email-xiaosuo@gmail.com>
On Mon, Jul 26, 2010 at 05:19:19PM +0800, Changli Gao wrote:
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
> ----
> fs/dlm/netlink.c | 15 +--------------
> 1 file changed, 1 insertion(+), 14 deletions(-)
> diff --git a/fs/dlm/netlink.c b/fs/dlm/netlink.c
> index 2c6ad51..ef17e01 100644
> --- a/fs/dlm/netlink.c
> +++ b/fs/dlm/netlink.c
> @@ -81,24 +81,11 @@ static struct genl_ops dlm_nl_ops = {
>
> int __init dlm_netlink_init(void)
> {
> - int rv;
> -
> - rv = genl_register_family(&family);
> - if (rv)
> - return rv;
> -
> - rv = genl_register_ops(&family, &dlm_nl_ops);
> - if (rv < 0)
> - goto err;
> - return 0;
> - err:
> - genl_unregister_family(&family);
> - return rv;
> + return genl_register_family_with_ops(&family, &dlm_nl_ops, 1);
> }
>
> void dlm_netlink_exit(void)
> {
> - genl_unregister_ops(&family, &dlm_nl_ops);
> genl_unregister_family(&family);
> }
Looks fine, ack.
Dave
WARNING: multiple messages have this Message-ID (diff)
From: David Teigland <teigland@redhat.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Christine Caulfield <ccaulfie@redhat.com>,
cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dlm: use genl_register_family_with_ops()
Date: Mon, 26 Jul 2010 12:04:40 -0400 [thread overview]
Message-ID: <20100726160440.GA18604@redhat.com> (raw)
In-Reply-To: <1280135959-17485-1-git-send-email-xiaosuo@gmail.com>
On Mon, Jul 26, 2010 at 05:19:19PM +0800, Changli Gao wrote:
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
> ----
> fs/dlm/netlink.c | 15 +--------------
> 1 file changed, 1 insertion(+), 14 deletions(-)
> diff --git a/fs/dlm/netlink.c b/fs/dlm/netlink.c
> index 2c6ad51..ef17e01 100644
> --- a/fs/dlm/netlink.c
> +++ b/fs/dlm/netlink.c
> @@ -81,24 +81,11 @@ static struct genl_ops dlm_nl_ops = {
>
> int __init dlm_netlink_init(void)
> {
> - int rv;
> -
> - rv = genl_register_family(&family);
> - if (rv)
> - return rv;
> -
> - rv = genl_register_ops(&family, &dlm_nl_ops);
> - if (rv < 0)
> - goto err;
> - return 0;
> - err:
> - genl_unregister_family(&family);
> - return rv;
> + return genl_register_family_with_ops(&family, &dlm_nl_ops, 1);
> }
>
> void dlm_netlink_exit(void)
> {
> - genl_unregister_ops(&family, &dlm_nl_ops);
> genl_unregister_family(&family);
> }
Looks fine, ack.
Dave
next prev parent reply other threads:[~2010-07-26 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 9:19 [PATCH] dlm: use genl_register_family_with_ops() Changli Gao
2010-07-26 16:04 ` David Teigland [this message]
2010-07-26 16:04 ` David Teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100726160440.GA18604@redhat.com \
--to=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.