From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Always journal quota file modifications
Date: Tue, 27 Jul 2010 09:37:04 -0400 [thread overview]
Message-ID: <20100727133704.GB18966@thunk.org> (raw)
In-Reply-To: <4C323BAC.5030101@redhat.com>
On Mon, Jul 05, 2010 at 03:08:12PM -0500, Eric Sandeen wrote:
> Jan Kara wrote:
> > When journaled quota options are not specified, we do writes
> > to quota files just in data=ordered mode. This actually causes
> > warnings from JBD2 about dirty journaled buffer because ext4_getblk
> > unconditionally treats a block allocated by it as metadata. Since
> > quota actually is filesystem metadata, the easiest way to get rid
> > of the warning is to always treat quota writes as metadata...
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
>
> Where are we at on this one? I was trawling through my old RH bugs
> today, and have one that this patch will resolve. Ted, did you
> get comfortable with it?
I've added this to the ext4 patch queue. (Going my backlog too,
before the merge window opens. :-)
- Ted
prev parent reply other threads:[~2010-07-27 13:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 14:23 [PATCH] ext4: Always journal quota file modifications Jan Kara
2010-06-02 21:39 ` Eric Sandeen
2010-06-02 23:46 ` Jan Kara
2010-06-03 9:07 ` Dmitry Monakhov
2010-06-03 11:54 ` Jan Kara
2010-06-03 12:53 ` tytso
2010-06-03 14:13 ` Dmitry Monakhov
2010-06-03 14:19 ` Jan Kara
2010-06-03 17:10 ` tytso
2010-06-04 14:45 ` Jan Kara
2010-06-03 16:47 ` Bernd Schubert
2010-07-05 20:08 ` Eric Sandeen
2010-07-27 13:37 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727133704.GB18966@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.