From: Arnd Bergmann <arnd@arndb.de>
To: devicetree-discuss@lists.ozlabs.org
Cc: sfr@canb.auug.org.au, microblaze-uclinux@itee.uq.edu.au,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
sparclinux@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
davem@davemloft.net
Subject: Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid()
Date: Tue, 27 Jul 2010 15:34:01 +0200 [thread overview]
Message-ID: <201007271534.01250.arnd@arndb.de> (raw)
In-Reply-To: <AANLkTikcV3jJUm_My-oK-drudSDz3M2iH1cWhxdt+W1s@mail.gmail.com>
On Tuesday 27 July 2010, Grant Likely wrote:
> > I suggest to go back to v2 of your patch where you use asm-generic/of.h.
>
> Stephen suggested dropping asm-generic/of.h. I'm happy to do it either way.
I don't mind adding stuff to asm-generic, but I think in this case it would
be easier to keep this in linux/of.h because there is nothing wrong with
all architectures including it.
Most files in asm-generic are there only for historical reasons, where some
architectures use them but others don't. IMHO we should use the include/linux
headers preferred for new stuff though.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: devicetree-discuss@lists.ozlabs.org
Cc: Grant Likely <grant.likely@secretlab.ca>,
Sam Ravnborg <sam@ravnborg.org>,
sfr@canb.auug.org.au, microblaze-uclinux@itee.uq.edu.au,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
sparclinux@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid()
Date: Tue, 27 Jul 2010 13:34:01 +0000 [thread overview]
Message-ID: <201007271534.01250.arnd@arndb.de> (raw)
In-Reply-To: <AANLkTikcV3jJUm_My-oK-drudSDz3M2iH1cWhxdt+W1s@mail.gmail.com>
On Tuesday 27 July 2010, Grant Likely wrote:
> > I suggest to go back to v2 of your patch where you use asm-generic/of.h.
>
> Stephen suggested dropping asm-generic/of.h. I'm happy to do it either way.
I don't mind adding stuff to asm-generic, but I think in this case it would
be easier to keep this in linux/of.h because there is nothing wrong with
all architectures including it.
Most files in asm-generic are there only for historical reasons, where some
architectures use them but others don't. IMHO we should use the include/linux
headers preferred for new stuff though.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: devicetree-discuss@lists.ozlabs.org
Cc: Grant Likely <grant.likely@secretlab.ca>,
Sam Ravnborg <sam@ravnborg.org>,
sfr@canb.auug.org.au, microblaze-uclinux@itee.uq.edu.au,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
sparclinux@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid()
Date: Tue, 27 Jul 2010 15:34:01 +0200 [thread overview]
Message-ID: <201007271534.01250.arnd@arndb.de> (raw)
In-Reply-To: <AANLkTikcV3jJUm_My-oK-drudSDz3M2iH1cWhxdt+W1s@mail.gmail.com>
On Tuesday 27 July 2010, Grant Likely wrote:
> > I suggest to go back to v2 of your patch where you use asm-generic/of.h.
>
> Stephen suggested dropping asm-generic/of.h. I'm happy to do it either way.
I don't mind adding stuff to asm-generic, but I think in this case it would
be easier to keep this in linux/of.h because there is nothing wrong with
all architectures including it.
Most files in asm-generic are there only for historical reasons, where some
architectures use them but others don't. IMHO we should use the include/linux
headers preferred for new stuff though.
Arnd
next prev parent reply other threads:[~2010-07-27 13:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 22:04 [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid() Grant Likely
2010-07-26 22:04 ` Grant Likely
2010-07-26 22:04 ` [PATCH v3] of: Create asm-generic/of.h and provide default Grant Likely
2010-07-26 22:05 ` [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid() Grant Likely
2010-07-26 22:05 ` Grant Likely
2010-07-26 22:05 ` Grant Likely
2010-07-26 22:05 ` [PATCH v3] of: Create asm-generic/of.h and provide default Grant Likely
2010-07-26 22:26 ` [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid() Sam Ravnborg
2010-07-26 22:26 ` Sam Ravnborg
2010-07-26 22:26 ` [PATCH v3] of: Create asm-generic/of.h and provide default Sam Ravnborg
2010-07-26 22:42 ` [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid() Grant Likely
2010-07-26 22:42 ` Grant Likely
2010-07-26 22:42 ` Grant Likely
2010-07-26 22:42 ` [PATCH v3] of: Create asm-generic/of.h and provide default Grant Likely
2010-07-26 22:48 ` [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid() David Miller
2010-07-26 22:48 ` David Miller
2010-07-26 22:48 ` David Miller
2010-07-26 22:48 ` [PATCH v3] of: Create asm-generic/of.h and provide default David Miller
2010-07-26 22:51 ` [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid() Grant Likely
2010-07-26 22:51 ` Grant Likely
2010-07-26 22:51 ` Grant Likely
2010-07-26 22:51 ` [PATCH v3] of: Create asm-generic/of.h and provide default Grant Likely
2010-07-27 1:38 ` [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid() David Miller
2010-07-27 1:38 ` David Miller
2010-07-27 1:38 ` David Miller
2010-07-27 1:38 ` [PATCH v3] of: Create asm-generic/of.h and provide default David Miller
2010-07-27 1:57 ` [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid() Grant Likely
2010-07-27 1:57 ` Grant Likely
2010-07-27 1:57 ` Grant Likely
2010-07-27 1:57 ` [PATCH v3] of: Create asm-generic/of.h and provide default Grant Likely
2010-07-27 13:34 ` Arnd Bergmann [this message]
2010-07-27 13:34 ` [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid() Arnd Bergmann
2010-07-27 13:34 ` Arnd Bergmann
2010-07-27 16:52 ` Sam Ravnborg
2010-07-27 16:52 ` Sam Ravnborg
2010-07-27 16:52 ` [PATCH v3] of: Create asm-generic/of.h and provide default Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007271534.01250.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=sam@ravnborg.org \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.