Re: xf86-video-intel: configure.ac

Re: xf86-video-intel: configure.ac

[Julien Cristau]

[-- Attachment #1.1: Type: text/plain, Size: 1065 bytes --]

On Mon, Jul 26, 2010 at 16:44:47 -0700, Jesse Barnes wrote:

>  configure.ac |    2 ++
>  1 file changed, 2 insertions(+)
> 
> New commits:
> commit d580fa82a1cf339d2d1fd1055d137c0b23cd04f3
> Author: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
> Date:   Mon Jul 26 16:44:19 2010 -0700
> 
>     configure.ac: add xi and gl requirements
>     
>     Could probably be earlier versions, but having these here makes packaging
>     easier.
> 
> diff --git a/configure.ac b/configure.ac
> index d5989a6..4edd07b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -81,6 +81,8 @@ XORG_DRIVER_CHECK_EXT(DPMSExtension, xextproto)
>  PKG_CHECK_MODULES(XORG, [xorg-server >= 1.6 xproto fontsproto $REQUIRED_MODULES])
>  PKG_CHECK_MODULES(DRM, [libdrm >= 2.4.21])
>  PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
> +PKG_CHECK_MODULES(XI, [xi >= 1.3])
> +PKG_CHECK_MODULES(GL, [gl >= 7.7.0])
>  
>  sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`
>  

May I ask why?  None of these seem necessary…

Cheers,
Julien

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 219 bytes --]

_______________________________________________
xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: xf86-video-intel: configure.ac

[Gaetan Nadon]

[-- Attachment #1.1.1: Type: text/plain, Size: 732 bytes --]

On Tue, 2010-07-27 at 15:41 +0200, Julien Cristau wrote:

> > +PKG_CHECK_MODULES(XI, [xi >= 1.3])
> > +PKG_CHECK_MODULES(GL, [gl >= 7.7.0])
> >  
> >  sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`
> >  
> 
> May I ask why?  None of these seem necessary…
> 


Jesse,

Will the --disable-dri option still work now that the module cannot be
configured without the gl package?

Will xi version 1.3 version be "too recent" when built against a 1.6
server?
The 1.6 server does not depend on libXi.

It's great to have accurate dependencies checking. Just by looking at
the configuration of this driver,
it has an explicit requirement to support server 1.6 and later, and to
work without dri.

Gaetan



[-- Attachment #1.1.2: Type: text/html, Size: 1392 bytes --]

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 219 bytes --]

_______________________________________________
xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: xf86-video-intel: configure.ac

[Jesse Barnes]

On Tue, 27 Jul 2010 15:41:35 +0200
Julien Cristau <jcristau@debian.org> wrote:

> On Mon, Jul 26, 2010 at 16:44:47 -0700, Jesse Barnes wrote:
> 
> >  configure.ac |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > New commits:
> > commit d580fa82a1cf339d2d1fd1055d137c0b23cd04f3
> > Author: Jesse Barnes <jbarnes@virtuousgeek.org>
> > Date:   Mon Jul 26 16:44:19 2010 -0700
> > 
> >     configure.ac: add xi and gl requirements
> >     
> >     Could probably be earlier versions, but having these here makes packaging
> >     easier.
> > 
> > diff --git a/configure.ac b/configure.ac
> > index d5989a6..4edd07b 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -81,6 +81,8 @@ XORG_DRIVER_CHECK_EXT(DPMSExtension, xextproto)
> >  PKG_CHECK_MODULES(XORG, [xorg-server >= 1.6 xproto fontsproto $REQUIRED_MODULES])
> >  PKG_CHECK_MODULES(DRM, [libdrm >= 2.4.21])
> >  PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
> > +PKG_CHECK_MODULES(XI, [xi >= 1.3])
> > +PKG_CHECK_MODULES(GL, [gl >= 7.7.0])
> >  
> >  sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`
> >  
> 
> May I ask why?  None of these seem necessary…

Apparently MeeGo does automatic packaging based on configure.ac, so
Arjan requested that these be added to make that easier.

-- 
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: xf86-video-intel: configure.ac

[Jesse Barnes]

On Tue, 27 Jul 2010 10:50:24 -0400
Gaetan Nadon <memsize@videotron.ca> wrote:

> On Tue, 2010-07-27 at 15:41 +0200, Julien Cristau wrote:
> 
> > > +PKG_CHECK_MODULES(XI, [xi >= 1.3])
> > > +PKG_CHECK_MODULES(GL, [gl >= 7.7.0])
> > >  
> > >  sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`
> > >  
> > 
> > May I ask why?  None of these seem necessary…
> > 
> 
> 
> Jesse,
> 
> Will the --disable-dri option still work now that the module cannot be
> configured without the gl package?
> 
> Will xi version 1.3 version be "too recent" when built against a 1.6
> server?
> The 1.6 server does not depend on libXi.
> 
> It's great to have accurate dependencies checking. Just by looking at
> the configuration of this driver,
> it has an explicit requirement to support server 1.6 and later, and to
> work without dri.

I didn't test with the --disable-dri option, we could put the pkg
requirement under a DRI check if needed.

I also haven't tried building against a 1.6 server for a long time, if
we need changes to support that I can make them as well.

-- 
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: xf86-video-intel: configure.ac

[Julien Cristau]

On Tue, Jul 27, 2010 at 08:25:13 -0700, Jesse Barnes wrote:

> Apparently MeeGo does automatic packaging based on configure.ac, so
> Arjan requested that these be added to make that easier.

So we're adding fictional dependencies based on meego brokenness?
Do you have more details on the issues they were having?

Cheers,
Julien

Re: [Intel-gfx] xf86-video-intel: configure.ac

[Daniel Stone]

[-- Attachment #1.1: Type: text/plain, Size: 763 bytes --]

Hi,

On Tue, Jul 27, 2010 at 05:44:39PM +0200, Julien Cristau wrote:
> On Tue, Jul 27, 2010 at 08:25:13 -0700, Jesse Barnes wrote:
> > Apparently MeeGo does automatic packaging based on configure.ac, so
> > Arjan requested that these be added to make that easier.
> 
> So we're adding fictional dependencies based on meego brokenness?
> Do you have more details on the issues they were having?

That's pretty awesome.  In either case, xi is almost certainly the wrong
module.  If the requirement is to have X11/extensions/XI.h and friends
for server headers, then not only should that dep be in the server
rather than a driver which blatantly has nothing to do with input, but
you want inputproto rather than xi, which is libXi.

Cheers,
Daniel

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 219 bytes --]

_______________________________________________
xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: xf86-video-intel: configure.ac

[Jesse Barnes]

On Tue, 27 Jul 2010 17:00:28 +0100
Daniel Stone <daniel@fooishbar.org> wrote:

> Hi,
> 
> On Tue, Jul 27, 2010 at 05:44:39PM +0200, Julien Cristau wrote:
> > On Tue, Jul 27, 2010 at 08:25:13 -0700, Jesse Barnes wrote:
> > > Apparently MeeGo does automatic packaging based on configure.ac, so
> > > Arjan requested that these be added to make that easier.
> > 
> > So we're adding fictional dependencies based on meego brokenness?
> > Do you have more details on the issues they were having?
> 
> That's pretty awesome.  In either case, xi is almost certainly the wrong
> module.  If the requirement is to have X11/extensions/XI.h and friends
> for server headers, then not only should that dep be in the server
> rather than a driver which blatantly has nothing to do with input, but
> you want inputproto rather than xi, which is libXi.

Agreed, since Arjan requested this I just pinged him about why he
thinks xi belongs here.  We don't directly include files from either
package, so putting the requirement on the server side makes more sense.

And I think the dep on glproto should be sufficient for the GL stuff we
use...

-- 
Jesse Barnes, Intel Open Source Technology Center

Re: xf86-video-intel: configure.ac

[Jesse Barnes]

On Tue, 27 Jul 2010 17:00:28 +0100
Daniel Stone <daniel@fooishbar.org> wrote:

> Hi,
> 
> On Tue, Jul 27, 2010 at 05:44:39PM +0200, Julien Cristau wrote:
> > On Tue, Jul 27, 2010 at 08:25:13 -0700, Jesse Barnes wrote:
> > > Apparently MeeGo does automatic packaging based on configure.ac, so
> > > Arjan requested that these be added to make that easier.
> > 
> > So we're adding fictional dependencies based on meego brokenness?
> > Do you have more details on the issues they were having?
> 
> That's pretty awesome.  In either case, xi is almost certainly the wrong
> module.  If the requirement is to have X11/extensions/XI.h and friends
> for server headers, then not only should that dep be in the server
> rather than a driver which blatantly has nothing to do with input, but
> you want inputproto rather than xi, which is libXi.

Yep, sorry, my fault.  I should have checked these out more; Arjan
showed me the logs and it looks like the server is missing a dep on xi:

<arjan> In file included from /usr/include/xorg/scrnintstr.h:58:0,
<arjan>                  from /usr/include/xorg/xf86str.h:39,
<arjan>                  from /usr/include/xorg/xf86.h:46,
<arjan>                  from uxa-priv.h:37,
<arjan>                  from uxa.c:37:
<arjan> /usr/include/xorg/dix.h:57:31: fatal error: 
X11/extensions/XI.h: No such file or directory

and glproto is missing a dep on GL:

<arjan> In file included from i810.h:60:0,
<arjan>                  from i810_accel.c:41:
<arjan> /usr/include/GL/glxint.h:36:19: fatal error: GL/gl.h: No such file or directory

So we'll have to fix those instead.
-- 
Jesse Barnes, Intel Open Source Technology Center

Re: [Intel-gfx] xf86-video-intel: configure.ac

[Daniel Stone]

[-- Attachment #1.1: Type: text/plain, Size: 1638 bytes --]

On Tue, Jul 27, 2010 at 09:34:01AM -0700, Jesse Barnes wrote:
> On Tue, 27 Jul 2010 17:00:28 +0100
> Daniel Stone <daniel-rLtY4a/8tF1rovVCs/uTlw@public.gmane.org> wrote:
> > On Tue, Jul 27, 2010 at 05:44:39PM +0200, Julien Cristau wrote:
> > > On Tue, Jul 27, 2010 at 08:25:13 -0700, Jesse Barnes wrote:
> > > > Apparently MeeGo does automatic packaging based on configure.ac, so
> > > > Arjan requested that these be added to make that easier.
> > > 
> > > So we're adding fictional dependencies based on meego brokenness?
> > > Do you have more details on the issues they were having?
> > 
> > That's pretty awesome.  In either case, xi is almost certainly the wrong
> > module.  If the requirement is to have X11/extensions/XI.h and friends
> > for server headers, then not only should that dep be in the server
> > rather than a driver which blatantly has nothing to do with input, but
> > you want inputproto rather than xi, which is libXi.
> 
> Yep, sorry, my fault.  I should have checked these out more; Arjan
> showed me the logs and it looks like the server is missing a dep on xi:
> 
> <arjan> In file included from /usr/include/xorg/scrnintstr.h:58:0,
> <arjan>                  from /usr/include/xorg/xf86str.h:39,
> <arjan>                  from /usr/include/xorg/xf86.h:46,
> <arjan>                  from uxa-priv.h:37,
> <arjan>                  from uxa.c:37:
> <arjan> /usr/include/xorg/dix.h:57:31: fatal error: 
> X11/extensions/XI.h: No such file or directory

That would be a dep on inputproto. :) xi only gives you XInput.h and
XInput2.h, both client-only headers.

Cheers,
Daniel

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 219 bytes --]

_______________________________________________
xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [Intel-gfx] xf86-video-intel: configure.ac

[Julien Cristau]

On Tue, Jul 27, 2010 at 17:39:11 +0100, Daniel Stone wrote:

> > <arjan> In file included from /usr/include/xorg/scrnintstr.h:58:0,
> > <arjan>                  from /usr/include/xorg/xf86str.h:39,
> > <arjan>                  from /usr/include/xorg/xf86.h:46,
> > <arjan>                  from uxa-priv.h:37,
> > <arjan>                  from uxa.c:37:
> > <arjan> /usr/include/xorg/dix.h:57:31: fatal error: 
> > X11/extensions/XI.h: No such file or directory
> 
> That would be a dep on inputproto. :) xi only gives you XInput.h and
> XInput2.h, both client-only headers.
> 
And it's already fixed.

http://cgit.freedesktop.org/xorg/xserver/commit/?id=32c706c4ffd7433dbfc79dba8785b1510d2f053f

The GL one is more annoying.

Cheers,
Julien
_______________________________________________
xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: xf86-video-intel: configure.ac

[Jesse Barnes]

On Tue, 27 Jul 2010 17:39:11 +0100
Daniel Stone <daniel@fooishbar.org> wrote:

> On Tue, Jul 27, 2010 at 09:34:01AM -0700, Jesse Barnes wrote:
> > On Tue, 27 Jul 2010 17:00:28 +0100
> > Daniel Stone <daniel@fooishbar.org> wrote:
> > > On Tue, Jul 27, 2010 at 05:44:39PM +0200, Julien Cristau wrote:
> > > > On Tue, Jul 27, 2010 at 08:25:13 -0700, Jesse Barnes wrote:
> > > > > Apparently MeeGo does automatic packaging based on configure.ac, so
> > > > > Arjan requested that these be added to make that easier.
> > > > 
> > > > So we're adding fictional dependencies based on meego brokenness?
> > > > Do you have more details on the issues they were having?
> > > 
> > > That's pretty awesome.  In either case, xi is almost certainly the wrong
> > > module.  If the requirement is to have X11/extensions/XI.h and friends
> > > for server headers, then not only should that dep be in the server
> > > rather than a driver which blatantly has nothing to do with input, but
> > > you want inputproto rather than xi, which is libXi.
> > 
> > Yep, sorry, my fault.  I should have checked these out more; Arjan
> > showed me the logs and it looks like the server is missing a dep on xi:
> > 
> > <arjan> In file included from /usr/include/xorg/scrnintstr.h:58:0,
> > <arjan>                  from /usr/include/xorg/xf86str.h:39,
> > <arjan>                  from /usr/include/xorg/xf86.h:46,
> > <arjan>                  from uxa-priv.h:37,
> > <arjan>                  from uxa.c:37:
> > <arjan> /usr/include/xorg/dix.h:57:31: fatal error: 
> > X11/extensions/XI.h: No such file or directory
> 
> That would be a dep on inputproto. :) xi only gives you XInput.h and
> XInput2.h, both client-only headers.

Right, and the server already has this, so either Arjan has an old
server or his autopackager is broken.

-- 
Jesse Barnes, Intel Open Source Technology Center

Re: [Intel-gfx] xf86-video-intel: configure.ac

[Gaetan Nadon]

[-- Attachment #1.1.1: Type: text/plain, Size: 663 bytes --]

On Tue, 2010-07-27 at 18:47 +0200, Julien Cristau wrote:

> The GL one is more annoying.
> 

glproto includes gl.h which is in the mesa source. The mesa package
depends on glproto.
This will become a circular dependency if glproto is fixed to depend on
gl. I was surprised to see a protocol
including a header file from it's package implementation. 

The patch is not responsible for this situation, but it shows that the
packager cannot rely
on configuration dependencies alone to function properly. Not to mention
there are
most likely missing dependencies. Build tool chain dependencies are one
thing, 
but running dependencies are another. 

[-- Attachment #1.1.2: Type: text/html, Size: 1013 bytes --]

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 219 bytes --]

_______________________________________________
xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: xf86-video-intel: configure.ac

[Chris Wilson]

On Tue, 27 Jul 2010 09:34:01 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> and glproto is missing a dep on GL:
> 
> <arjan> In file included from i810.h:60:0,
> <arjan>                  from i810_accel.c:41:
> <arjan> /usr/include/GL/glxint.h:36:19: fatal error: GL/gl.h: No such file or directory

>From memory, I think this is just a bit of idiocacy in the driver
inappropriately using a GL type, i.e. for a variable unconnected with
any of the GL interfaces.
-- 
Chris Wilson, Intel Open Source Technology Centre

Re: xf86-video-intel: configure.ac

[Kristian Høgsberg]

On Wed, Jul 28, 2010 at 4:42 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Tue, 27 Jul 2010 09:34:01 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>> and glproto is missing a dep on GL:
>>
>> <arjan> In file included from i810.h:60:0,
>> <arjan>                  from i810_accel.c:41:
>> <arjan> /usr/include/GL/glxint.h:36:19: fatal error: GL/gl.h: No such file or directory
>
> From memory, I think this is just a bit of idiocacy in the driver
> inappropriately using a GL type, i.e. for a variable unconnected with
> any of the GL interfaces.

There was a few gratuitous uses of GLuint in the core driver that I
just removed.  Then the legacy i810 driver still had the code to
create and set GLX visuals, which hasn't been used for years now (we
get the configs from the dri driver even for dri1 since 2007).    I
removed that chunk of code, which means that the legacy driver wont
work with X server before 2007, but the purpose of the legacy code is
to run the old driver on new servers anyway (right?).

Kristian
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx