Re: [PATCH 5/6] libxl: portiblity fixes

[Christoph Egger <Christoph.Egger@amd.com>]

On Tuesday 27 July 2010 19:00:07 Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH 5/6] libxl: portiblity fixes"):
> >  LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o
> > +LIBXL_OBJS-$(CONFIG_Linux) += libxl_linux.o
> > +LIBXL_OBJS-$(CONFIG_NetBSD) += libxl_netbsd.o
>
> As previously discussed, these files should probably be called
> libxl_blktap2.c and libxl_noblktap2.c or some such.

Discussed between you and Ian Campell. Both of you believe
that blktap support on NetBSD will never exist, right ?

blktap support for NetBSD is under development and will be
very different in its implementation.

> > +const char *libxl_blktap_devpath(struct libxl_ctx *ctx,
> > +                                 const char *disk,
> > +                                 libxl_disk_phystype phystype)
>
> You seem to be moving code about by adding it in one patch and
> deleting it in another;

In this case I call this 'factor out OS dependent code'.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632