From: Olaf Hering <olaf@aepfle.de>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] xenpaging: correct order of linker options to avoid link errors with recent toolchains
Date: Wed, 28 Jul 2010 18:15:24 +0200 [thread overview]
Message-ID: <20100728161524.GA7525@aepfle.de> (raw)
In-Reply-To: <19536.21860.12916.94743@mariner.uk.xensource.com>
On Wed, Jul 28, Ian Jackson wrote:
> Olaf Hering writes ("[PATCH] xenpaging: correct order of linker options to avoid link errors with recent toolchains"):
> > -LDFLAGS += $(LDFLAGS_libxenctrl) $(LDFLAGS_libxenstore)
> > +XENPAGING_LIBS = $(LDFLAGS_libxenctrl) $(LDFLAGS_libxenstore)
>
> *_LIBS = $(LDFLAGS_*) ?
>
> surely some mistake.
Ian,
LDFLAGS_libxenctrl is defined in tools/Rules.mk and used in several
Makefiles. Are you suggesting to rename these variables and update all
users?
Also, its not clear to me why the place of LDFLAGS matters. In another
thread it was stated that -static may behave different. Whats the reason
for that?
Olaf
next prev parent reply other threads:[~2010-07-28 16:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 12:55 [PATCH] xenpaging: correct order of linker options to avoid link errors with recent toolchains Olaf Hering
2010-07-28 14:02 ` Ian Jackson
2010-07-28 15:47 ` Olaf Hering
2010-07-28 16:05 ` Ian Jackson
2010-07-28 16:15 ` Olaf Hering [this message]
2010-07-29 15:16 ` Ian Jackson
2010-07-29 15:20 ` Olaf Hering
2010-07-29 15:39 ` Ian Jackson
2010-08-01 9:51 ` [PATCH] split LDLIBS from LDFLAGS to fix link errors in " Olaf Hering
2010-08-11 13:44 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100728161524.GA7525@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.