* [ath9k-devel] [PATCH] ath9k: enable serialize_regmode for non-PCIE AR9160
@ 2010-07-28 15:15 ` John W. Linville
0 siblings, 0 replies; 3+ messages in thread
From: John W. Linville @ 2010-07-28 15:15 UTC (permalink / raw)
To: ath9k-devel
https://bugzilla.kernel.org/show_bug.cgi?id=16476
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
Is there a better (i.e. either more precise or more inclusive) test
to be using here?
drivers/net/wireless/ath/ath9k/hw.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index c33f17d..1041965 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -537,7 +537,8 @@ static int __ath9k_hw_init(struct ath_hw *ah)
if (ah->config.serialize_regmode == SER_REG_MODE_AUTO) {
if (ah->hw_version.macVersion == AR_SREV_VERSION_5416_PCI ||
- (AR_SREV_9280(ah) && !ah->is_pciexpress)) {
+ ((AR_SREV_9160(ah) || AR_SREV_9280(ah)) &&
+ !ah->is_pciexpress)) {
ah->config.serialize_regmode =
SER_REG_MODE_ON;
} else {
--
1.7.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] ath9k: enable serialize_regmode for non-PCIE AR9160
@ 2010-07-28 15:15 ` John W. Linville
0 siblings, 0 replies; 3+ messages in thread
From: John W. Linville @ 2010-07-28 15:15 UTC (permalink / raw)
To: linux-wireless; +Cc: ath9k-devel, John W. Linville
https://bugzilla.kernel.org/show_bug.cgi?id=16476
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
Is there a better (i.e. either more precise or more inclusive) test
to be using here?
drivers/net/wireless/ath/ath9k/hw.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index c33f17d..1041965 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -537,7 +537,8 @@ static int __ath9k_hw_init(struct ath_hw *ah)
if (ah->config.serialize_regmode == SER_REG_MODE_AUTO) {
if (ah->hw_version.macVersion == AR_SREV_VERSION_5416_PCI ||
- (AR_SREV_9280(ah) && !ah->is_pciexpress)) {
+ ((AR_SREV_9160(ah) || AR_SREV_9280(ah)) &&
+ !ah->is_pciexpress)) {
ah->config.serialize_regmode =
SER_REG_MODE_ON;
} else {
--
1.7.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [ath9k-devel] [PATCH] ath9k: enable serialize_regmode for non-PCIE AR9160
2010-07-28 15:15 ` John W. Linville
(?)
@ 2010-07-28 18:08 ` Luis R. Rodriguez
-1 siblings, 0 replies; 3+ messages in thread
From: Luis R. Rodriguez @ 2010-07-28 18:08 UTC (permalink / raw)
To: ath9k-devel
On Wed, Jul 28, 2010 at 08:15:27AM -0700, John W. Linville wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=16476
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Acked-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Wow nice find, thanks!
> ---
> Is there a better (i.e. either more precise or more inclusive) test
> to be using here?
This is fine unless there is an AR9160 that is AHB, Felix would know. Also
if you can Cc stable, that would be appreciated
Luis
> drivers/net/wireless/ath/ath9k/hw.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
> index c33f17d..1041965 100644
> --- a/drivers/net/wireless/ath/ath9k/hw.c
> +++ b/drivers/net/wireless/ath/ath9k/hw.c
> @@ -537,7 +537,8 @@ static int __ath9k_hw_init(struct ath_hw *ah)
>
> if (ah->config.serialize_regmode == SER_REG_MODE_AUTO) {
> if (ah->hw_version.macVersion == AR_SREV_VERSION_5416_PCI ||
> - (AR_SREV_9280(ah) && !ah->is_pciexpress)) {
> + ((AR_SREV_9160(ah) || AR_SREV_9280(ah)) &&
> + !ah->is_pciexpress)) {
> ah->config.serialize_regmode =
> SER_REG_MODE_ON;
> } else {
> --
> 1.7.1.1
>
> _______________________________________________
> ath9k-devel mailing list
> ath9k-devel at lists.ath9k.org
> https://lists.ath9k.org/mailman/listinfo/ath9k-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-28 18:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-28 15:15 [ath9k-devel] [PATCH] ath9k: enable serialize_regmode for non-PCIE AR9160 John W. Linville
2010-07-28 15:15 ` John W. Linville
2010-07-28 18:08 ` [ath9k-devel] " Luis R. Rodriguez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.