From: Ondrej Zary <linux@rainbow-software.org>
To: Russell King <linux@arm.linux.org.uk>
Cc: linux-fbdev@vger.kernel.org,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: [PATCH] cyber2000fb: fix console in truecolor modes
Date: Thu, 29 Jul 2010 20:40:54 +0000 [thread overview]
Message-ID: <201007292240.55525.linux@rainbow-software.org> (raw)
In-Reply-To: <201007282159.19583.linux@rainbow-software.org>
Return value was not set to 0 in setcolreg() with truecolor modes. This causes
fb_set_cmap() to abort after first color, resulting in blank palette - and
blank console in 24bpp and 32bpp modes.
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
--- linux-2.6.35-rc3-/drivers/video/cyber2000fb.c 2010-07-29 22:27:28.000000000 +0200
+++ linux-2.6.35-rc3/drivers/video/cyber2000fb.c 2010-07-29 22:29:04.000000000 +0200
@@ -392,6 +392,7 @@ cyber2000fb_setcolreg(u_int regno, u_int
pseudo_val |= convert_bitfield(red, &var->red);
pseudo_val |= convert_bitfield(green, &var->green);
pseudo_val |= convert_bitfield(blue, &var->blue);
+ ret = 0;
break;
}
--
Ondrej Zary
WARNING: multiple messages have this Message-ID (diff)
From: Ondrej Zary <linux@rainbow-software.org>
To: Russell King <linux@arm.linux.org.uk>
Cc: linux-fbdev@vger.kernel.org,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: [PATCH] cyber2000fb: fix console in truecolor modes
Date: Thu, 29 Jul 2010 22:40:54 +0200 [thread overview]
Message-ID: <201007292240.55525.linux@rainbow-software.org> (raw)
In-Reply-To: <201007282159.19583.linux@rainbow-software.org>
Return value was not set to 0 in setcolreg() with truecolor modes. This causes
fb_set_cmap() to abort after first color, resulting in blank palette - and
blank console in 24bpp and 32bpp modes.
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
--- linux-2.6.35-rc3-/drivers/video/cyber2000fb.c 2010-07-29 22:27:28.000000000 +0200
+++ linux-2.6.35-rc3/drivers/video/cyber2000fb.c 2010-07-29 22:29:04.000000000 +0200
@@ -392,6 +392,7 @@ cyber2000fb_setcolreg(u_int regno, u_int
pseudo_val |= convert_bitfield(red, &var->red);
pseudo_val |= convert_bitfield(green, &var->green);
pseudo_val |= convert_bitfield(blue, &var->blue);
+ ret = 0;
break;
}
--
Ondrej Zary
next prev parent reply other threads:[~2010-07-29 20:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 19:59 cyber2000fb - 24bpp and 32bpp modes not working Ondrej Zary
2010-07-28 19:59 ` Ondrej Zary
2010-07-29 20:40 ` Ondrej Zary [this message]
2010-07-29 20:40 ` [PATCH] cyber2000fb: fix console in truecolor modes Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007292240.55525.linux@rainbow-software.org \
--to=linux@rainbow-software.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.