From: Dan Carpenter <error27@gmail.com>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [Bug] check return of kmalloc()
Date: Thu, 29 Jul 2010 23:39:09 +0000 [thread overview]
Message-ID: <20100729233909.GX26313@bicker> (raw)
In-Reply-To: <20100729191557.GA9784@albatros>
On Thu, Jul 29, 2010 at 11:15:57PM +0400, Vasiliy Kulikov wrote:
> Hi,
>
> I've discovered that some btrfs code doesn't check whether kmalloc()
> call succeeded. I poorly understand what this code does and how it can
> be changed, maybe it would be happy with __GFP_NOFAIL.
>
> Also there are BUG_ON() after kmalloc()'s, if they could be changed not
> to panic it would be great.
>
>
Yeah. That doesn't seem right.
I have pushed a change to smatch to find places like that. It's valid
to call BUG_ON() for allocation failures during init so the check is
disabled by default. Use the --spammy option to enable it.
dcarpenter@bicker:~/progs/kernel/devel$ kchecker --spammy fs/btrfs/tree-log.c
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CHECK fs/btrfs/tree-log.c
fs/btrfs/tree-log.c +823 add_inode_ref(43) warn: bug on allocation failure 'name'
fs/btrfs/tree-log.c +868 add_inode_ref(88) warn: bug on allocation failure 'victim_name'
fs/btrfs/tree-log.c +3123 btrfs_recover_log_trees(58) error: 'wc.replay_dest' dereferencing possible ERR_PTR()
CC [M] fs/btrfs/tree-log.o
dcarpenter@bicker:~/progs/kernel/devel$
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [Bug] check return of kmalloc()
Date: Fri, 30 Jul 2010 01:39:09 +0200 [thread overview]
Message-ID: <20100729233909.GX26313@bicker> (raw)
In-Reply-To: <20100729191557.GA9784@albatros>
On Thu, Jul 29, 2010 at 11:15:57PM +0400, Vasiliy Kulikov wrote:
> Hi,
>
> I've discovered that some btrfs code doesn't check whether kmalloc()
> call succeeded. I poorly understand what this code does and how it can
> be changed, maybe it would be happy with __GFP_NOFAIL.
>
> Also there are BUG_ON() after kmalloc()'s, if they could be changed not
> to panic it would be great.
>
>
Yeah. That doesn't seem right.
I have pushed a change to smatch to find places like that. It's valid
to call BUG_ON() for allocation failures during init so the check is
disabled by default. Use the --spammy option to enable it.
dcarpenter@bicker:~/progs/kernel/devel$ kchecker --spammy fs/btrfs/tree-log.c
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CHECK fs/btrfs/tree-log.c
fs/btrfs/tree-log.c +823 add_inode_ref(43) warn: bug on allocation failure 'name'
fs/btrfs/tree-log.c +868 add_inode_ref(88) warn: bug on allocation failure 'victim_name'
fs/btrfs/tree-log.c +3123 btrfs_recover_log_trees(58) error: 'wc.replay_dest' dereferencing possible ERR_PTR()
CC [M] fs/btrfs/tree-log.o
dcarpenter@bicker:~/progs/kernel/devel$
regards,
dan carpenter
next prev parent reply other threads:[~2010-07-29 23:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 19:15 [Bug] check return of kmalloc() Vasiliy Kulikov
2010-07-29 19:15 ` Vasiliy Kulikov
2010-07-29 23:39 ` Dan Carpenter [this message]
2010-07-29 23:39 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100729233909.GX26313@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.