All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Colin Cross <ccross@google.com>
Cc: linux-tegra@vger.kernel.org,
	spi-devel-general@lists.sourceforge.net,
	Erik Gilling <konkers@android.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] spi: add spi_tegra driver
Date: Fri, 30 Jul 2010 09:54:43 +0200	[thread overview]
Message-ID: <20100730075443.GA17814@avionic-design.de> (raw)
In-Reply-To: <1280450224-25118-1-git-send-email-ccross@google.com>


[-- Attachment #1.1: Type: text/plain, Size: 1138 bytes --]

* Colin Cross wrote:
> From: Erik Gilling <konkers@android.com>
> 
> CC: spi-devel-general@lists.sourceforge.net
> Signed-off-by: Erik Gilling <konkers@android.com>
> ---
> This patch depends on the Tegra APB DMA driver:
> [PATCH] [ARM] tegra: Add APB DMA support
> ---
>  drivers/spi/Kconfig     |    6 +
>  drivers/spi/Makefile    |    1 +
>  drivers/spi/spi_tegra.c |  651 +++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 658 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/spi/spi_tegra.c
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 91c2f4f..c07e0de 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -298,6 +298,12 @@ config SPI_STMP3XXX
>  	help
>  	  SPI driver for Freescale STMP37xx/378x SoC SSP interface
>  
> +config SPI_TEGRA
> +	tristate "Nvidia Tegra SPI controller"
> +	depends on ARCH_TEGRA
> +	help
> +	  SPI driver for NVidia Tegra SoCs
> +
[...]

Since you say this driver depends on the APB DMA driver, should this not be
expressed as a Kconfig dependency? Something like:

	select TEGRA_SYSTEM_DMA

Thierry

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@avionic-design.de (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: add spi_tegra driver
Date: Fri, 30 Jul 2010 09:54:43 +0200	[thread overview]
Message-ID: <20100730075443.GA17814@avionic-design.de> (raw)
In-Reply-To: <1280450224-25118-1-git-send-email-ccross@google.com>

* Colin Cross wrote:
> From: Erik Gilling <konkers@android.com>
> 
> CC: spi-devel-general at lists.sourceforge.net
> Signed-off-by: Erik Gilling <konkers@android.com>
> ---
> This patch depends on the Tegra APB DMA driver:
> [PATCH] [ARM] tegra: Add APB DMA support
> ---
>  drivers/spi/Kconfig     |    6 +
>  drivers/spi/Makefile    |    1 +
>  drivers/spi/spi_tegra.c |  651 +++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 658 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/spi/spi_tegra.c
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 91c2f4f..c07e0de 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -298,6 +298,12 @@ config SPI_STMP3XXX
>  	help
>  	  SPI driver for Freescale STMP37xx/378x SoC SSP interface
>  
> +config SPI_TEGRA
> +	tristate "Nvidia Tegra SPI controller"
> +	depends on ARCH_TEGRA
> +	help
> +	  SPI driver for NVidia Tegra SoCs
> +
[...]

Since you say this driver depends on the APB DMA driver, should this not be
expressed as a Kconfig dependency? Something like:

	select TEGRA_SYSTEM_DMA

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100730/2c9c6a2d/attachment-0001.sig>

  reply	other threads:[~2010-07-30  7:54 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-30  0:37 [PATCH] spi: add spi_tegra driver Colin Cross
2010-07-30  0:37 ` Colin Cross
2010-07-30  7:54 ` Thierry Reding [this message]
2010-07-30  7:54   ` Thierry Reding
     [not found]   ` <20100730075443.GA17814-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2010-08-02 18:48     ` Erik Gilling
2010-08-02 18:48       ` Erik Gilling
2010-08-01  6:21 ` Grant Likely
2010-08-01  6:21   ` Grant Likely
     [not found]   ` <AANLkTimUm_wj+gyxTa=X+845kLj1sZ9GF+jsmsBwxnLN-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-08-12  0:31     ` Erik Gilling
2010-08-12  0:31       ` Erik Gilling
2010-08-12 15:24       ` Russell King - ARM Linux
2010-08-12 15:24         ` Russell King - ARM Linux
     [not found]         ` <20100812152424.GB31982-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2010-08-12 18:44           ` Erik Gilling
2010-08-12 18:44             ` Erik Gilling
     [not found] ` <1280450224-25118-1-git-send-email-ccross-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2010-08-12  0:47   ` [PATCH v2] " Erik Gilling
2010-08-12  0:47     ` Erik Gilling
     [not found]     ` <1281574023-25160-1-git-send-email-konkers-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
2010-08-12 19:54       ` Grant Likely
2010-08-12 19:54         ` Grant Likely
     [not found]         ` <AANLkTim4nL+Re=qc55CGS+ksq+ACtGe=vqOeGQ3HbQWM-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-08-25 21:22           ` Erik Gilling
2010-08-25 21:22             ` Erik Gilling
     [not found]             ` <AANLkTincgapUK5ncs_t3ax=1Kt_56GdR_RVwRqdCm5ge-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-08-27 19:26               ` Erik Gilling
2010-08-27 19:26                 ` Erik Gilling
     [not found]                 ` <AANLkTin4HxVLt=4VH-NQWhB-p_2EpX_yoTcwEOTJP3m_-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-08-27 20:13                   ` Grant Likely
2010-08-27 20:13                     ` Grant Likely
2010-08-25 21:23       ` [PATCH v3] " Erik Gilling
2010-08-25 21:23         ` Erik Gilling
2010-09-01 22:16         ` [PATCH v4] " Erik Gilling
2010-09-01 22:16           ` Erik Gilling
2010-09-01 22:18           ` Erik Gilling
2010-09-01 22:18             ` Erik Gilling
2010-09-02 14:22           ` Grant Likely
2010-09-02 14:22             ` Grant Likely
     [not found]             ` <AANLkTimonLa1mUVSHR=QnR48HPtAZ5BW3BsVsg7MWALy-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-10  6:31               ` Grant Likely
2010-10-10  6:31                 ` Grant Likely
     [not found]                 ` <AANLkTini_PA3J+R4gEP4DzFpcAxHhdmDbcXxOtj2h81O-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-11 21:01                   ` Erik Gilling
2010-10-11 21:01                     ` Erik Gilling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100730075443.GA17814@avionic-design.de \
    --to=thierry.reding@avionic-design.de \
    --cc=ccross@google.com \
    --cc=konkers@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.