All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, vapier@gentoo.org,
	pavel@ucw.cz, akpm@linux-foundation.org,
	khilman@deeprootsystems.com, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, eric.y.miao@gmail.com
Subject: Re: [PATCH] Input: Make ADS7846 independent on regulator
Date: Sat, 31 Jul 2010 09:03:52 +0200	[thread overview]
Message-ID: <201007310903.52921.marek.vasut@gmail.com> (raw)
In-Reply-To: <20100731063329.GA23620@core.coreip.homeip.net>

Dne So 31. července 2010 08:33:29 Dmitry Torokhov napsal(a):
> Hi Marek,
> 
> On Sat, Jul 31, 2010 at 07:45:08AM +0200, Marek Vasut wrote:
> > In case regulator was not found, ADS7846 failed to probe.
> > 
> > This fixes a problem on some Sharp Zaurus devices, where there is no
> > regulator present and yet the touchscreen is used.
> 
> Too many ifdefs to my taste... Can we have ads7846_regulator_enable()
> and friends stubbed out in case !CONFIG_REGULATOR?

Hi,

I believe you should ask the regulator guys about these. We can certainly just 
remove the ifdefs (I was thinking about it, because it poluted the code quality 
quite a bit). Just removing the ifdefs shouldn't cause any harm.

Cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Input: Make ADS7846 independent on regulator
Date: Sat, 31 Jul 2010 09:03:52 +0200	[thread overview]
Message-ID: <201007310903.52921.marek.vasut@gmail.com> (raw)
In-Reply-To: <20100731063329.GA23620@core.coreip.homeip.net>

Dne So 31. ?ervence 2010 08:33:29 Dmitry Torokhov napsal(a):
> Hi Marek,
> 
> On Sat, Jul 31, 2010 at 07:45:08AM +0200, Marek Vasut wrote:
> > In case regulator was not found, ADS7846 failed to probe.
> > 
> > This fixes a problem on some Sharp Zaurus devices, where there is no
> > regulator present and yet the touchscreen is used.
> 
> Too many ifdefs to my taste... Can we have ads7846_regulator_enable()
> and friends stubbed out in case !CONFIG_REGULATOR?

Hi,

I believe you should ask the regulator guys about these. We can certainly just 
remove the ifdefs (I was thinking about it, because it poluted the code quality 
quite a bit). Just removing the ifdefs shouldn't cause any harm.

Cheers

WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marek.vasut@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, vapier@gentoo.org,
	pavel@ucw.cz, akpm@linux-foundation.org,
	khilman@deeprootsystems.com, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, eric.y.miao@gmail.com
Subject: Re: [PATCH] Input: Make ADS7846 independent on regulator
Date: Sat, 31 Jul 2010 09:03:52 +0200	[thread overview]
Message-ID: <201007310903.52921.marek.vasut@gmail.com> (raw)
In-Reply-To: <20100731063329.GA23620@core.coreip.homeip.net>

Dne So 31. července 2010 08:33:29 Dmitry Torokhov napsal(a):
> Hi Marek,
> 
> On Sat, Jul 31, 2010 at 07:45:08AM +0200, Marek Vasut wrote:
> > In case regulator was not found, ADS7846 failed to probe.
> > 
> > This fixes a problem on some Sharp Zaurus devices, where there is no
> > regulator present and yet the touchscreen is used.
> 
> Too many ifdefs to my taste... Can we have ads7846_regulator_enable()
> and friends stubbed out in case !CONFIG_REGULATOR?

Hi,

I believe you should ask the regulator guys about these. We can certainly just 
remove the ifdefs (I was thinking about it, because it poluted the code quality 
quite a bit). Just removing the ifdefs shouldn't cause any harm.

Cheers

  reply	other threads:[~2010-07-31  7:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-31  5:45 [PATCH] Input: Make ADS7846 independent on regulator Marek Vasut
2010-07-31  5:45 ` Marek Vasut
2010-07-31  6:33 ` Dmitry Torokhov
2010-07-31  6:33   ` Dmitry Torokhov
2010-07-31  7:03   ` Marek Vasut [this message]
2010-07-31  7:03     ` Marek Vasut
2010-07-31  7:03     ` Marek Vasut
2010-10-06 17:16 ` Linus Walleij
2010-10-06 17:16   ` Linus Walleij
2010-10-06 17:16   ` Linus Walleij
2010-10-06 17:52   ` Mark Brown
2010-10-06 17:52     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201007310903.52921.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=eric.y.miao@gmail.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.