From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Dave Airlie <airlied@redhat.com>
Cc: Nicolas Kaiser <nikai@nikai.net>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: fixed brace, spacing and whitespace coding style issues
Date: Mon, 2 Aug 2010 08:15:07 -0700 [thread overview]
Message-ID: <20100802081507.5fa6f52d@virtuousgeek.org> (raw)
In-Reply-To: <1280708213.2393.2.camel@clockmaker-el6>
On Mon, 02 Aug 2010 10:16:53 +1000
Dave Airlie <airlied@redhat.com> wrote:
> On Wed, 2010-07-14 at 16:11 +0200, Nicolas Kaiser wrote:
> > Fixed brace, spacing and whitespace coding style issues.
>
> Failed to apply to drm-core-next, might always be a pain to get
> something like this to apply though, whitespace isn't top of my
> priorities most days.
I think you should just reject it, unless it comes as part of a series
with actual work in it. At least that's been my policy lately...
--
Jesse Barnes, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Dave Airlie <airlied@redhat.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: fixed brace, spacing and whitespace coding style issues
Date: Mon, 2 Aug 2010 08:15:07 -0700 [thread overview]
Message-ID: <20100802081507.5fa6f52d@virtuousgeek.org> (raw)
In-Reply-To: <1280708213.2393.2.camel@clockmaker-el6>
On Mon, 02 Aug 2010 10:16:53 +1000
Dave Airlie <airlied@redhat.com> wrote:
> On Wed, 2010-07-14 at 16:11 +0200, Nicolas Kaiser wrote:
> > Fixed brace, spacing and whitespace coding style issues.
>
> Failed to apply to drm-core-next, might always be a pain to get
> something like this to apply though, whitespace isn't top of my
> priorities most days.
I think you should just reject it, unless it comes as part of a series
with actual work in it. At least that's been my policy lately...
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-08-02 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 14:11 [PATCH] drm: fixed brace, spacing and whitespace coding style issues Nicolas Kaiser
2010-08-02 0:16 ` Dave Airlie
2010-08-02 10:13 ` [PATCH] [drm-core-next] drm: Fixed " Nicolas Kaiser
2010-08-02 15:15 ` Jesse Barnes [this message]
2010-08-02 15:15 ` [PATCH] drm: fixed brace, spacing and whitespace " Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100802081507.5fa6f52d@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikai@nikai.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.