From: Tony Lindgren <tony@atomide.com>
To: Sukumar Ghorai <s-ghorai@ti.com>
Cc: linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 0/3] omap3 nand: cleanup exiting platform related code
Date: Mon, 2 Aug 2010 15:52:24 +0300 [thread overview]
Message-ID: <20100802125224.GJ12293@atomide.com> (raw)
In-Reply-To: <1278666886-30293-1-git-send-email-s-ghorai@ti.com>
* Sukumar Ghorai <s-ghorai@ti.com> [100709 12:09]:
> The following set of patches applies on top of for-next branch.
> http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git
> Patches verified on: omap3430-SDP, omap3630-sdp, zoom3 and beagle board
>
> And these are the patches required to address the following input -
> 1. The NAND driver needs to stop tinkering with the GPMC registers
> The omap General Purpose Memory Controller (GPMC) registers are omap
> specific, and not driver specific. Tinkering with these registers can
> cause issues with the other devices on the GPMC.
>
> 2. Passing hardcoded GPMC_CS0_BASE needs to go from the board files
> Passing hardcoded GPMC virtual addressess is sure way to mess up things.
> This should all become unnecessary once the NAND drivers stops messing
> with the GPMC registers directly.
Thanks, I'll add this series into omap-for-linus.
Regards,
Tony
> Discussion: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg27630.html
>
> No code change from previous version.
> Looping linux-arm-kernel mailing list with new version.
>
> Changes in this series -
> gpmc_hwcontrol() function in gpmc.c, break into various small function.
> v6: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg31936.html
>
> Unused function removed.
> v5: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg30305.html
>
> Functions related to ecc and prefetch engine are optimized.
> v4: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg29458.html
>
> Few functionality was missing like - There should be some locking as only
> one chipselect can use the ECC or prefetch engine at a time. If you have
> NAND in two chipselects, bad things would happen.
> v3: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg28715.html
>
> Additionally, it was needed to implement more functions for the platform
> init code to use.
> v2: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg28467.html
>
> v1: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg28164.html
>
>
> Sukumar Ghorai (3):
> omap3 gpmc: functionality enhancement
> omap3 nand: cleanup virtual address usages
> omap3 nand: fix issue in board file to detect nand
> arch/arm/mach-omap2/board-cm-t35.c | 20 +--
> arch/arm/mach-omap2/board-devkit8000.c | 25 +---
> arch/arm/mach-omap2/board-omap3beagle.c | 24 +---
> arch/arm/mach-omap2/board-omap3touchbook.c | 25 +---
> arch/arm/mach-omap2/board-overo.c | 24 +---
> arch/arm/mach-omap2/board-sdp-flash.c | 5 -
> arch/arm/mach-omap2/gpmc-nand.c | 38 +---
> arch/arm/mach-omap2/gpmc.c | 285 ++++++++++++++++++++++++++--
> arch/arm/plat-omap/include/plat/gpmc.h | 42 ++++-
> arch/arm/plat-omap/include/plat/nand.h | 6 +-
> drivers/mtd/nand/omap2.c | 218 ++++++----------------
> 11 files changed, 371 insertions(+), 341 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 0/3] omap3 nand: cleanup exiting platform related code
Date: Mon, 2 Aug 2010 15:52:24 +0300 [thread overview]
Message-ID: <20100802125224.GJ12293@atomide.com> (raw)
In-Reply-To: <1278666886-30293-1-git-send-email-s-ghorai@ti.com>
* Sukumar Ghorai <s-ghorai@ti.com> [100709 12:09]:
> The following set of patches applies on top of for-next branch.
> http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git
> Patches verified on: omap3430-SDP, omap3630-sdp, zoom3 and beagle board
>
> And these are the patches required to address the following input -
> 1. The NAND driver needs to stop tinkering with the GPMC registers
> The omap General Purpose Memory Controller (GPMC) registers are omap
> specific, and not driver specific. Tinkering with these registers can
> cause issues with the other devices on the GPMC.
>
> 2. Passing hardcoded GPMC_CS0_BASE needs to go from the board files
> Passing hardcoded GPMC virtual addressess is sure way to mess up things.
> This should all become unnecessary once the NAND drivers stops messing
> with the GPMC registers directly.
Thanks, I'll add this series into omap-for-linus.
Regards,
Tony
> Discussion: http://www.mail-archive.com/linux-omap at vger.kernel.org/msg27630.html
>
> No code change from previous version.
> Looping linux-arm-kernel mailing list with new version.
>
> Changes in this series -
> gpmc_hwcontrol() function in gpmc.c, break into various small function.
> v6: http://www.mail-archive.com/linux-omap at vger.kernel.org/msg31936.html
>
> Unused function removed.
> v5: http://www.mail-archive.com/linux-omap at vger.kernel.org/msg30305.html
>
> Functions related to ecc and prefetch engine are optimized.
> v4: http://www.mail-archive.com/linux-omap at vger.kernel.org/msg29458.html
>
> Few functionality was missing like - There should be some locking as only
> one chipselect can use the ECC or prefetch engine at a time. If you have
> NAND in two chipselects, bad things would happen.
> v3: http://www.mail-archive.com/linux-omap at vger.kernel.org/msg28715.html
>
> Additionally, it was needed to implement more functions for the platform
> init code to use.
> v2: http://www.mail-archive.com/linux-omap at vger.kernel.org/msg28467.html
>
> v1: http://www.mail-archive.com/linux-omap at vger.kernel.org/msg28164.html
>
>
> Sukumar Ghorai (3):
> omap3 gpmc: functionality enhancement
> omap3 nand: cleanup virtual address usages
> omap3 nand: fix issue in board file to detect nand
> arch/arm/mach-omap2/board-cm-t35.c | 20 +--
> arch/arm/mach-omap2/board-devkit8000.c | 25 +---
> arch/arm/mach-omap2/board-omap3beagle.c | 24 +---
> arch/arm/mach-omap2/board-omap3touchbook.c | 25 +---
> arch/arm/mach-omap2/board-overo.c | 24 +---
> arch/arm/mach-omap2/board-sdp-flash.c | 5 -
> arch/arm/mach-omap2/gpmc-nand.c | 38 +---
> arch/arm/mach-omap2/gpmc.c | 285 ++++++++++++++++++++++++++--
> arch/arm/plat-omap/include/plat/gpmc.h | 42 ++++-
> arch/arm/plat-omap/include/plat/nand.h | 6 +-
> drivers/mtd/nand/omap2.c | 218 ++++++----------------
> 11 files changed, 371 insertions(+), 341 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-08-02 12:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 9:14 [PATCH v7 0/3] omap3 nand: cleanup exiting platform related code Sukumar Ghorai
2010-07-09 9:14 ` Sukumar Ghorai
2010-07-09 9:14 ` [PATCH v7 1/3] omap3 gpmc: functionality enhancement Sukumar Ghorai
2010-07-09 9:14 ` Sukumar Ghorai
2010-07-09 9:14 ` [PATCH v7 2/3] omap3 nand: cleanup virtual address usages Sukumar Ghorai
2010-07-09 9:14 ` Sukumar Ghorai
2010-07-09 9:14 ` [PATCH v7 3/3] omap3 nand: fix issue in board file to detect nand Sukumar Ghorai
2010-07-09 9:14 ` Sukumar Ghorai
2010-08-02 12:52 ` Tony Lindgren [this message]
2010-08-02 12:52 ` [PATCH v7 0/3] omap3 nand: cleanup exiting platform related code Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100802125224.GJ12293@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=s-ghorai@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.