All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Andrew Clayton <andrew@digital-domain.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mel@csn.ul.ie>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Dave Chinner <david@fromorbit.com>,
	Chris Mason <chris.mason@oracle.com>,
	Nick Piggin <npiggin@suse.de>, Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@infradead.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	"pvz@pvz.pp.se" <pvz@pvz.pp.se>,
	"bgamari@gmail.com" <bgamari@gmail.com>,
	"larppaxyz@gmail.com" <larppaxyz@gmail.com>,
	"seanj@xyke.com" <seanj@xyke.com>,
	"kernel-bugs.dev1world@spamgourmet.com" <kernel-bugs
Subject: Re: Bug 12309 - Large I/O operations result in poor interactive performance and high iowait times
Date: Tue, 3 Aug 2010 08:45:11 +0800	[thread overview]
Message-ID: <20100803004511.GB5198@localhost> (raw)
In-Reply-To: <AANLkTimPicvVXnfc1qkuWekzmEz18E=t50yhzaxpToae@mail.gmail.com>

> > What in my mind is (without any throttling)
> >
> >        if (PageSwapcache(page)) {
> >                if (bdi_write_congested(bdi))
> 
> You mentioned following as.
> 
> "However !bdi_write_congested(bdi) is now unconditionally true for the
> swapper_space, which means any process can do swap out to a congested
> queue and block there."
> 
> But you used bdi_write_congested in here.
> Which is right?

Ah sorry, I was also cheated by the name.. bdi_write_congested()
won't work for swap_backing_dev_info.  Anyway you may take it as
"pseudo" code :)

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Wu Fengguang <fengguang.wu@intel.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Andrew Clayton <andrew@digital-domain.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mel@csn.ul.ie>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Dave Chinner <david@fromorbit.com>,
	Chris Mason <chris.mason@oracle.com>,
	Nick Piggin <npiggin@suse.de>, Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@infradead.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	"pvz@pvz.pp.se" <pvz@pvz.pp.se>,
	"bgamari@gmail.com" <bgamari@gmail.com>,
	"larppaxyz@gmail.com" <larppaxyz@gmail.com>,
	"seanj@xyke.com" <seanj@xyke.com>,
	"kernel-bugs.dev1world@spamgourmet.com"
	<kernel-bugs.dev1world@spamgourmet.com>,
	"akatopaz@gmail.com" <akatopaz@gmail.com>,
	"frankrq2009@gmx.com" <frankrq2009@gmx.com>,
	"thomas.pi@arcor.de" <thomas.pi@arcor.de>,
	"spawels13@gmail.com" <spawels13@gmail.com>,
	"vshader@gmail.com" <vshader@gmail.com>,
	"rockorequin@hotmail.com" <rockorequin@hotmail.com>,
	"ylalym@gmail.com" <ylalym@gmail.com>,
	"theholyettlz@googlemail.com" <theholyettlz@googlemail.com>,
	"hassium@yandex.ru" <hassium@yandex.ru>
Subject: Re: Bug 12309 - Large I/O operations result in poor interactive performance and high iowait times
Date: Tue, 3 Aug 2010 08:45:11 +0800	[thread overview]
Message-ID: <20100803004511.GB5198@localhost> (raw)
In-Reply-To: <AANLkTimPicvVXnfc1qkuWekzmEz18E=t50yhzaxpToae@mail.gmail.com>

> > What in my mind is (without any throttling)
> >
> > A  A  A  A if (PageSwapcache(page)) {
> > A  A  A  A  A  A  A  A if (bdi_write_congested(bdi))
> 
> You mentioned following as.
> 
> "However !bdi_write_congested(bdi) is now unconditionally true for the
> swapper_space, which means any process can do swap out to a congested
> queue and block there."
> 
> But you used bdi_write_congested in here.
> Which is right?

Ah sorry, I was also cheated by the name.. bdi_write_congested()
won't work for swap_backing_dev_info.  Anyway you may take it as
"pseudo" code :)

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-08-03  0:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100802003616.5b31ed8b@digital-domain.net>
2010-08-02  8:12 ` Bug 12309 - Large I/O operations result in poor interactive performance and high iowait times Wu Fengguang
2010-08-02  8:12   ` Wu Fengguang
2010-08-02  8:12   ` Wu Fengguang
2010-08-02  9:16   ` KOSAKI Motohiro
2010-08-02  9:16     ` KOSAKI Motohiro
2010-08-02  9:16     ` KOSAKI Motohiro
2010-08-02 11:57     ` Wu Fengguang
2010-08-02 11:57       ` Wu Fengguang
2010-08-02 23:36       ` Minchan Kim
2010-08-02 23:36         ` Minchan Kim
2010-08-03  0:45         ` Wu Fengguang [this message]
2010-08-03  0:45           ` Wu Fengguang
2010-08-03  6:35       ` KOSAKI Motohiro
2010-08-03  6:35         ` KOSAKI Motohiro
2010-08-02 23:32   ` Minchan Kim
2010-08-02 23:32     ` Minchan Kim
2010-08-02 23:32     ` Minchan Kim
2010-08-03  1:40     ` Wu Fengguang
2010-08-03  1:40       ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100803004511.GB5198@localhost \
    --to=fengguang.wu@intel.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrew@digital-domain.net \
    --cc=axboe@kernel.dk \
    --cc=bgamari@gmail.com \
    --cc=chris.mason@oracle.com \
    --cc=david@fromorbit.com \
    --cc=hannes@cmpxchg.org \
    --cc=hch@infradead.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=larppaxyz@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=minchan.kim@gmail.com \
    --cc=npiggin@suse.de \
    --cc=pvz@pvz.pp.se \
    --cc=riel@redhat.com \
    --cc=seanj@xyke.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.