All of lore.kernel.org
 help / color / mirror / Atom feed
From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] USB-serial dummy cable driver
Date: Tue, 3 Aug 2010 20:21:07 +0200	[thread overview]
Message-ID: <201008032021.07504.marek.vasut@gmail.com> (raw)
In-Reply-To: <20100803174912.GA2190@suse.de>

Dne ?t 3. srpna 2010 19:49:12 Greg KH napsal(a):
> On Tue, Aug 03, 2010 at 07:36:39PM +0200, Marek Vasut wrote:
> > Dne ?t 3. srpna 2010 18:38:26 Greg KH napsal(a):
> > > On Tue, Aug 03, 2010 at 06:14:15PM +0200, Marek Vasut wrote:
> > > > Dne ?t 3. srpna 2010 00:47:18 Greg KH napsal(a):
> > > > > On Mon, Aug 02, 2010 at 08:00:07AM +0200, Marek Vasut wrote:
> > > > > > This driver is used to implement USB-serial like behaviour over
> > > > > > dummy
> > > > > > 
> > > > > > USB cables. These are used in the following devices:
> > > > > > 	Funsoft Serial USB driver
> > > > > > 	Genesys Logic GL620USB USB Laplink cable
> > > > > > 	HP4x (48/49) Serial cable
> > > > > > 	Motorola phones
> > > > > > 	Siemens USB-MPI Serial USB driver
> > > > > > 	ViVOpay USB Serial Driver
> > > > > > 	ZIO Motherboard USB driver
> > > > > 
> > > > > I like the idea, but not the name :)
> > > > 
> > > > Please don't expect miracles from me after 26 hours without sleep ;-)
> > > > 
> > > > > Ideally, all of these would be able to be handled by the usb-serial
> > > > > generic driver directly.
> > > > 
> > > > I just noticed that one. Stupid me.
> > > > 
> > > > > But really, having these multiple drivers is a good thing, they
> > > > > properly convey to the user what the device is, and it gives these
> > > > > developers and companies a sense of ownership over the code, and
> > > > > that matters at times.
> > > > > 
> > > > > So you lost the names of the devices with this patch, which isn't
> > > > > good.
> > > > 
> > > > Sheesh ... that's true, but having pile of copies of the same code is
> > > > not good either.
> > > 
> > > I agree, that's why I said it should be reduced.
> > > 
> > > > Can't we then just deprecate all these drivers and set correct udev
> > > > rules?
> > > 
> > > udev can not change the name of the device in sysfs, or the name in the
> > > kernel of the device.
> > 
> > That's right, but it can bind the generic driver with the hardware. And
> > who would care about the driver name, really ? The interface just
> > appears and that's what matters (to me and probably to users) ...
> 
> There are persistant device links in /dev/serial/ that might care about
> the driver name.  We don't want to break them, right?

We can start a slow migration though. Eg. push the serial-generic as a way-to-go 
so the distro teams can pick this change and incorporate it into their stuff.

Maybe just mark all those drivers as "DEPRECATED" and add a note there "use 
generic-serial".
> 
> thanks,
> 
> greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marek.vasut@gmail.com>
To: Greg KH <gregkh@suse.de>
Cc: linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
	nm127@freemail.hu, linux-kernel@vger.kernel.org,
	maxinbjohn@gmail.com, forest.bond@outpostembedded.com,
	vijaykumar@zilogic.com
Subject: Re: [PATCH] USB-serial dummy cable driver
Date: Tue, 3 Aug 2010 20:21:07 +0200	[thread overview]
Message-ID: <201008032021.07504.marek.vasut@gmail.com> (raw)
In-Reply-To: <20100803174912.GA2190@suse.de>

Dne Út 3. srpna 2010 19:49:12 Greg KH napsal(a):
> On Tue, Aug 03, 2010 at 07:36:39PM +0200, Marek Vasut wrote:
> > Dne Út 3. srpna 2010 18:38:26 Greg KH napsal(a):
> > > On Tue, Aug 03, 2010 at 06:14:15PM +0200, Marek Vasut wrote:
> > > > Dne Út 3. srpna 2010 00:47:18 Greg KH napsal(a):
> > > > > On Mon, Aug 02, 2010 at 08:00:07AM +0200, Marek Vasut wrote:
> > > > > > This driver is used to implement USB-serial like behaviour over
> > > > > > dummy
> > > > > > 
> > > > > > USB cables. These are used in the following devices:
> > > > > > 	Funsoft Serial USB driver
> > > > > > 	Genesys Logic GL620USB USB Laplink cable
> > > > > > 	HP4x (48/49) Serial cable
> > > > > > 	Motorola phones
> > > > > > 	Siemens USB-MPI Serial USB driver
> > > > > > 	ViVOpay USB Serial Driver
> > > > > > 	ZIO Motherboard USB driver
> > > > > 
> > > > > I like the idea, but not the name :)
> > > > 
> > > > Please don't expect miracles from me after 26 hours without sleep ;-)
> > > > 
> > > > > Ideally, all of these would be able to be handled by the usb-serial
> > > > > generic driver directly.
> > > > 
> > > > I just noticed that one. Stupid me.
> > > > 
> > > > > But really, having these multiple drivers is a good thing, they
> > > > > properly convey to the user what the device is, and it gives these
> > > > > developers and companies a sense of ownership over the code, and
> > > > > that matters at times.
> > > > > 
> > > > > So you lost the names of the devices with this patch, which isn't
> > > > > good.
> > > > 
> > > > Sheesh ... that's true, but having pile of copies of the same code is
> > > > not good either.
> > > 
> > > I agree, that's why I said it should be reduced.
> > > 
> > > > Can't we then just deprecate all these drivers and set correct udev
> > > > rules?
> > > 
> > > udev can not change the name of the device in sysfs, or the name in the
> > > kernel of the device.
> > 
> > That's right, but it can bind the generic driver with the hardware. And
> > who would care about the driver name, really ? The interface just
> > appears and that's what matters (to me and probably to users) ...
> 
> There are persistant device links in /dev/serial/ that might care about
> the driver name.  We don't want to break them, right?

We can start a slow migration though. Eg. push the serial-generic as a way-to-go 
so the distro teams can pick this change and incorporate it into their stuff.

Maybe just mark all those drivers as "DEPRECATED" and add a note there "use 
generic-serial".
> 
> thanks,
> 
> greg k-h

  reply	other threads:[~2010-08-03 18:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-02  6:00 [PATCH] USB-serial dummy cable driver Marek Vasut
2010-08-02  6:00 ` Marek Vasut
2010-08-02 22:47 ` Greg KH
2010-08-02 22:47   ` Greg KH
2010-08-03 16:14   ` Marek Vasut
2010-08-03 16:14     ` Marek Vasut
2010-08-03 16:38     ` Greg KH
2010-08-03 16:38       ` Greg KH
2010-08-03 17:36       ` Marek Vasut
2010-08-03 17:36         ` Marek Vasut
2010-08-03 17:49         ` Greg KH
2010-08-03 17:49           ` Greg KH
2010-08-03 18:21           ` Marek Vasut [this message]
2010-08-03 18:21             ` Marek Vasut
2010-08-03 18:37             ` Greg KH
2010-08-03 18:37               ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201008032021.07504.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.