From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"G, Manjunath Kondaiah" <manjugk@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Gadiyar, Anand" <gadiyar@ti.com>
Subject: Re: [PATCH 2/3] OMAP3630: Add ES1.1 and ES1.2 detection
Date: Thu, 5 Aug 2010 12:36:22 +0300 [thread overview]
Message-ID: <20100805093621.GW9881@atomide.com> (raw)
In-Reply-To: <4C59B92C.5060300@ti.com>
* Nishanth Menon <nm@ti.com> [100804 21:55]:
> Tony Lindgren had written, on 08/04/2010 06:33 AM, the following:
> >From: Anand Gadiyar <gadiyar@ti.com>
> >+ default:
> >+ omap_revision = OMAP3630_REV_ES1_2;
> >+ omap_chip.oc |= CHIP_IS_OMAP3630ES1_2;
> >+ break;
> >+ }
>
> we need to add a break here. to jump out of the main switch statement.
> currently with ES1.0 3630, it reports as 3630 ES1.2
Argh.. It's merged already, care to do another patch
to fix this?
> Tested and verified on SDP3630 with OMAP3630 ES1.0
OK, thanks.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] OMAP3630: Add ES1.1 and ES1.2 detection
Date: Thu, 5 Aug 2010 12:36:22 +0300 [thread overview]
Message-ID: <20100805093621.GW9881@atomide.com> (raw)
In-Reply-To: <4C59B92C.5060300@ti.com>
* Nishanth Menon <nm@ti.com> [100804 21:55]:
> Tony Lindgren had written, on 08/04/2010 06:33 AM, the following:
> >From: Anand Gadiyar <gadiyar@ti.com>
> >+ default:
> >+ omap_revision = OMAP3630_REV_ES1_2;
> >+ omap_chip.oc |= CHIP_IS_OMAP3630ES1_2;
> >+ break;
> >+ }
>
> we need to add a break here. to jump out of the main switch statement.
> currently with ES1.0 3630, it reports as 3630 ES1.2
Argh.. It's merged already, care to do another patch
to fix this?
> Tested and verified on SDP3630 with OMAP3630 ES1.0
OK, thanks.
Tony
next prev parent reply other threads:[~2010-08-05 9:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 11:32 [PATCH 0/3] Few more omap patches for the 2.6.36 merge window Tony Lindgren
2010-08-04 11:32 ` Tony Lindgren
2010-08-04 11:32 ` [PATCH 1/3] omap: device: improve errors handling Tony Lindgren
2010-08-04 11:32 ` Tony Lindgren
2010-08-04 11:33 ` [PATCH 2/3] OMAP3630: Add ES1.1 and ES1.2 detection Tony Lindgren
2010-08-04 11:33 ` Tony Lindgren
2010-08-04 19:02 ` Nishanth Menon
2010-08-04 19:02 ` Nishanth Menon
2010-08-05 9:36 ` Tony Lindgren [this message]
2010-08-05 9:36 ` Tony Lindgren
2010-08-04 11:33 ` [PATCH 3/3] omap: 3630: disable TLL SAR on 3630 ES1 Tony Lindgren
2010-08-04 11:33 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100805093621.GW9881@atomide.com \
--to=tony@atomide.com \
--cc=gadiyar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=manjugk@ti.com \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.