From: Nick Piggin <npiggin@suse.de>
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Cc: Nick Piggin <npiggin@suse.de>,
andi.kleen@intel.com, alexs.shi@intel.com, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org
Subject: Re: scalability investigation: Where can I get your latest patches?
Date: Thu, 5 Aug 2010 21:44:38 +1000 [thread overview]
Message-ID: <20100805114438.GA9547@amd> (raw)
In-Reply-To: <1280883843.2125.20.camel@ymzhang.sh.intel.com>
On Wed, Aug 04, 2010 at 09:04:03AM +0800, Zhang, Yanmin wrote:
> We ran lots of benchmarks on many machines. Below is something to
> share with you.
>
> Improvement:
> 1) We get about 30% improvement with kbuild workload on Nehalem
> machines. It's hard to improve kbuild performance. Your tree does.
>
> Issues:
> 1) Compiling fails on a couple of file systems, such like CONFIG_ISO9660_FS=y.
> 2) dbenchthreads has about 50% regression. We connect a JBOD of 12 disks to
> a machine. Start 4 dbench threads per disk. We run the workload under
> a regular user account. If we run it under root account, we get 22%
> improvement instead of regression. The root cause is ACL checking.
> With your patch, do_path_lookup firstly goes through rcu steps which
> including a exec permission checking. With ACL, the __exec_permission
> always fails. Then a later nameidata_drop_rcu often fails as
> dentry->d_seq is changed.
Oh one other thing I wanted to ask about. d_seq changing should not
be too common. If the directory is renamed, or if it is turned negative
should be the only cases in which we should see a d_seq changes.
Or unless there is a bug and it is checking the wrong sequence or
against the wrong dentry. How often would you say nameidata_drop_rcu
fails (without the following acl rcu patches)?
WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <npiggin@suse.de>
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Cc: Nick Piggin <npiggin@suse.de>,
andi.kleen@intel.com, alexs.shi@intel.com, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org
Subject: Re: scalability investigation: Where can I get your latest patches?
Date: Thu, 5 Aug 2010 21:44:38 +1000 [thread overview]
Message-ID: <20100805114438.GA9547@amd> (raw)
In-Reply-To: <1280883843.2125.20.camel@ymzhang.sh.intel.com>
On Wed, Aug 04, 2010 at 09:04:03AM +0800, Zhang, Yanmin wrote:
> We ran lots of benchmarks on many machines. Below is something to
> share with you.
>
> Improvement:
> 1) We get about 30% improvement with kbuild workload on Nehalem
> machines. It's hard to improve kbuild performance. Your tree does.
>
> Issues:
> 1) Compiling fails on a couple of file systems, such like CONFIG_ISO9660_FS=y.
> 2) dbenchthreads has about 50% regression. We connect a JBOD of 12 disks to
> a machine. Start 4 dbench threads per disk. We run the workload under
> a regular user account. If we run it under root account, we get 22%
> improvement instead of regression. The root cause is ACL checking.
> With your patch, do_path_lookup firstly goes through rcu steps which
> including a exec permission checking. With ACL, the __exec_permission
> always fails. Then a later nameidata_drop_rcu often fails as
> dentry->d_seq is changed.
Oh one other thing I wanted to ask about. d_seq changing should not
be too common. If the directory is renamed, or if it is turned negative
should be the only cases in which we should see a d_seq changes.
Or unless there is a bug and it is checking the wrong sequence or
against the wrong dentry. How often would you say nameidata_drop_rcu
fails (without the following acl rcu patches)?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-08-05 11:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1278579387.2096.889.camel@ymzhang.sh.intel.com>
[not found] ` <20100720031201.GC21274@amd>
2010-08-04 1:04 ` scalability investigation: Where can I get your latest patches? Zhang, Yanmin
2010-08-04 1:04 ` Zhang, Yanmin
2010-08-04 7:21 ` Kleen, Andi
2010-08-04 7:21 ` Kleen, Andi
2010-08-04 7:58 ` Zhang, Yanmin
2010-08-04 7:58 ` Zhang, Yanmin
2010-08-04 8:06 ` Kleen, Andi
2010-08-04 8:50 ` Zhang, Yanmin
2010-08-04 8:50 ` Zhang, Yanmin
2010-08-05 10:57 ` Nick Piggin
2010-08-05 10:57 ` Nick Piggin
2010-08-05 10:55 ` Nick Piggin
2010-08-09 2:11 ` Zhang, Yanmin
2010-08-09 2:11 ` Zhang, Yanmin
2010-08-09 3:20 ` Zhang, Yanmin
2010-08-09 3:20 ` Zhang, Yanmin
2010-08-05 11:44 ` Nick Piggin [this message]
2010-08-05 11:44 ` Nick Piggin
2010-08-09 2:36 ` Zhang, Yanmin
2010-08-09 2:36 ` Zhang, Yanmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100805114438.GA9547@amd \
--to=npiggin@suse.de \
--cc=alexs.shi@intel.com \
--cc=andi.kleen@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.