From: Pavel Pisa <ppisa4lists@pikron.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 10/42] drivers/mmc/host: Adjust confusing if indentation
Date: Thu, 05 Aug 2010 20:57:53 +0000 [thread overview]
Message-ID: <201008052257.54039.ppisa4lists@pikron.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1008052219360.31692@ask.diku.dk>
On Thursday 05 August 2010 22:19:52 Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Good catch.
> ---
> drivers/mmc/host/imxmmc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/imxmmc.c b/drivers/mmc/host/imxmmc.c
> index 9a68ff4..5a950b1 100644
> --- a/drivers/mmc/host/imxmmc.c
> +++ b/drivers/mmc/host/imxmmc.c
> @@ -148,11 +148,12 @@ static int imxmci_start_clock(struct imxmci_host
> *host)
>
> while (delay--) {
> reg = readw(host->base + MMC_REG_STATUS);
> - if (reg & STATUS_CARD_BUS_CLK_RUN)
> + if (reg & STATUS_CARD_BUS_CLK_RUN) {
> /* Check twice before cut */
> reg = readw(host->base + MMC_REG_STATUS);
> if (reg & STATUS_CARD_BUS_CLK_RUN)
> return 0;
> + }
>
> if (test_bit(IMXMCI_PEND_STARTED_b, &host->pending_events))
> return 0;
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Pavel Pisa
e-mail: pisa@cmp.felk.cvut.cz
www: http://cmp.felk.cvut.cz/~pisa
university: http://dce.fel.cvut.cz/
company: http://www.pikron.com/
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Pisa <ppisa4lists@pikron.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-mmc@vger.kernel.org, kernel-janitors@vger.kernel.org,
Julia Lawall <julia@diku.dk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/42] drivers/mmc/host: Adjust confusing if indentation
Date: Thu, 5 Aug 2010 22:57:53 +0200 [thread overview]
Message-ID: <201008052257.54039.ppisa4lists@pikron.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1008052219360.31692@ask.diku.dk>
On Thursday 05 August 2010 22:19:52 Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Good catch.
> ---
> drivers/mmc/host/imxmmc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/imxmmc.c b/drivers/mmc/host/imxmmc.c
> index 9a68ff4..5a950b1 100644
> --- a/drivers/mmc/host/imxmmc.c
> +++ b/drivers/mmc/host/imxmmc.c
> @@ -148,11 +148,12 @@ static int imxmci_start_clock(struct imxmci_host
> *host)
>
> while (delay--) {
> reg = readw(host->base + MMC_REG_STATUS);
> - if (reg & STATUS_CARD_BUS_CLK_RUN)
> + if (reg & STATUS_CARD_BUS_CLK_RUN) {
> /* Check twice before cut */
> reg = readw(host->base + MMC_REG_STATUS);
> if (reg & STATUS_CARD_BUS_CLK_RUN)
> return 0;
> + }
>
> if (test_bit(IMXMCI_PEND_STARTED_b, &host->pending_events))
> return 0;
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Pavel Pisa
e-mail: pisa@cmp.felk.cvut.cz
www: http://cmp.felk.cvut.cz/~pisa
university: http://dce.fel.cvut.cz/
company: http://www.pikron.com/
WARNING: multiple messages have this Message-ID (diff)
From: ppisa4lists@pikron.com (Pavel Pisa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/42] drivers/mmc/host: Adjust confusing if indentation
Date: Thu, 5 Aug 2010 22:57:53 +0200 [thread overview]
Message-ID: <201008052257.54039.ppisa4lists@pikron.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1008052219360.31692@ask.diku.dk>
On Thursday 05 August 2010 22:19:52 Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Good catch.
> ---
> drivers/mmc/host/imxmmc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/imxmmc.c b/drivers/mmc/host/imxmmc.c
> index 9a68ff4..5a950b1 100644
> --- a/drivers/mmc/host/imxmmc.c
> +++ b/drivers/mmc/host/imxmmc.c
> @@ -148,11 +148,12 @@ static int imxmci_start_clock(struct imxmci_host
> *host)
>
> while (delay--) {
> reg = readw(host->base + MMC_REG_STATUS);
> - if (reg & STATUS_CARD_BUS_CLK_RUN)
> + if (reg & STATUS_CARD_BUS_CLK_RUN) {
> /* Check twice before cut */
> reg = readw(host->base + MMC_REG_STATUS);
> if (reg & STATUS_CARD_BUS_CLK_RUN)
> return 0;
> + }
>
> if (test_bit(IMXMCI_PEND_STARTED_b, &host->pending_events))
> return 0;
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Pavel Pisa
e-mail: pisa at cmp.felk.cvut.cz
www: http://cmp.felk.cvut.cz/~pisa
university: http://dce.fel.cvut.cz/
company: http://www.pikron.com/
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Pisa <ppisa4lists@pikron.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Julia Lawall <julia@diku.dk>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 10/42] drivers/mmc/host: Adjust confusing if indentation
Date: Thu, 5 Aug 2010 22:57:53 +0200 [thread overview]
Message-ID: <201008052257.54039.ppisa4lists@pikron.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1008052219360.31692@ask.diku.dk>
On Thursday 05 August 2010 22:19:52 Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Good catch.
> ---
> drivers/mmc/host/imxmmc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/imxmmc.c b/drivers/mmc/host/imxmmc.c
> index 9a68ff4..5a950b1 100644
> --- a/drivers/mmc/host/imxmmc.c
> +++ b/drivers/mmc/host/imxmmc.c
> @@ -148,11 +148,12 @@ static int imxmci_start_clock(struct imxmci_host
> *host)
>
> while (delay--) {
> reg = readw(host->base + MMC_REG_STATUS);
> - if (reg & STATUS_CARD_BUS_CLK_RUN)
> + if (reg & STATUS_CARD_BUS_CLK_RUN) {
> /* Check twice before cut */
> reg = readw(host->base + MMC_REG_STATUS);
> if (reg & STATUS_CARD_BUS_CLK_RUN)
> return 0;
> + }
>
> if (test_bit(IMXMCI_PEND_STARTED_b, &host->pending_events))
> return 0;
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Pavel Pisa
e-mail: pisa@cmp.felk.cvut.cz
www: http://cmp.felk.cvut.cz/~pisa
university: http://dce.fel.cvut.cz/
company: http://www.pikron.com/
next prev parent reply other threads:[~2010-08-05 20:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 20:19 [PATCH 10/42] drivers/mmc/host: Adjust confusing if indentation Julia Lawall
2010-08-05 20:19 ` Julia Lawall
2010-08-05 20:19 ` Julia Lawall
2010-08-05 20:57 ` Pavel Pisa [this message]
2010-08-05 20:57 ` Pavel Pisa
2010-08-05 20:57 ` Pavel Pisa
2010-08-05 20:57 ` Pavel Pisa
2010-08-27 21:08 ` [PATCH RESEND] " Chris Ball
2010-08-27 21:08 ` Chris Ball
2010-08-27 21:08 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008052257.54039.ppisa4lists@pikron.com \
--to=ppisa4lists@pikron.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.