From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Greg KH <greg@kroah.com>
Cc: linux-usb@vger.kernel.org,
"Michał Nazarewicz" <m.nazarewicz@samsung.com>,
linux-kernel@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@suse.de>
Subject: Re: [PATCH 2/2 v2] usb gadget: don't save bind callback in struct usb_configuration
Date: Fri, 6 Aug 2010 06:50:46 +0200 [thread overview]
Message-ID: <20100806045046.GA13345@pengutronix.de> (raw)
In-Reply-To: <20100805223435.GC18619@kroah.com>
On Thu, Aug 05, 2010 at 03:34:35PM -0700, Greg KH wrote:
> On Thu, Aug 05, 2010 at 11:50:17AM +0200, Uwe Kleine-König wrote:
> > The bind function is most of the time only called at init time so there is no
> > need to save a pointer to it in the configuration structure.
> >
> > This fixes many section mismatches reported by modpost.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Cc: Michał Nazarewicz <m.nazarewicz@samsung.com>
> > Cc: Greg Kroah-Hartman <gregkh@suse.de>
> > ---
> > changes since v1:
>
> I'm confused, can you resend what you want me to apply please?
Will do.
> Do I need to drop Michał's patch before applying yours?
I double checked that now, and there is one thing in Michał's patch that
is not fixed in mine. It's the hunk for drivers/usb/gadget/zero.c, as I
didn't touch struct usb_composite_driver yet. So expect three patches
in reply to this mail.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-08-06 4:50 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 14:49 [PATCH RFC] usb gadget: introduce usb_gadget_probe_driver Uwe Kleine-König
2010-07-30 14:49 ` Uwe Kleine-König
2010-07-30 15:14 ` Julia Lawall
2010-07-30 15:14 ` Julia Lawall
2010-07-30 15:28 ` Uwe Kleine-König
2010-07-30 15:28 ` Uwe Kleine-König
2010-07-30 15:16 ` Michał Nazarewicz
2010-07-30 15:16 ` Michał Nazarewicz
2010-07-30 15:26 ` Uwe Kleine-König
2010-07-30 15:26 ` Uwe Kleine-König
2010-07-30 16:08 ` Michał Nazarewicz
2010-07-30 16:08 ` Michał Nazarewicz
2010-07-30 18:57 ` Uwe Kleine-König
2010-07-30 18:57 ` Uwe Kleine-König
2010-07-30 18:46 ` David Brownell
2010-07-30 18:46 ` David Brownell
2010-08-02 9:39 ` Michał Nazarewicz
2010-08-02 9:39 ` Michał Nazarewicz
2010-08-02 12:39 ` [PATCH] usb gadget: don't save bind callback in struct usb_gadget_driver Uwe Kleine-König
2010-08-02 12:39 ` Uwe Kleine-König
2010-08-02 12:45 ` Christoph Hellwig
2010-08-02 12:51 ` Julia Lawall
2010-08-02 12:51 ` Julia Lawall
2010-08-02 13:12 ` Uwe Kleine-König
2010-08-02 13:12 ` Uwe Kleine-König
2010-08-02 22:54 ` Greg KH
2010-08-02 22:54 ` Greg KH
2010-08-03 7:40 ` Uwe Kleine-König
2010-08-02 14:25 ` Michał Nazarewicz
2010-08-02 14:25 ` Michał Nazarewicz
2010-08-02 18:25 ` Uwe Kleine-König
2010-08-02 18:27 ` [PATCH 1/2] " Uwe Kleine-König
2010-08-05 8:58 ` Michał Nazarewicz
2010-08-05 9:39 ` Uwe Kleine-König
2010-08-05 10:37 ` Michał Nazarewicz
2010-08-02 18:27 ` [PATCH 2/2] usb gadget: don't save bind callback in struct usb_configuration Uwe Kleine-König
2010-08-05 9:05 ` Michał Nazarewicz
2010-08-05 9:45 ` Uwe Kleine-König
2010-08-05 10:02 ` Michał Nazarewicz
2010-08-05 9:50 ` [PATCH 2/2 v2] " Uwe Kleine-König
2010-08-05 22:34 ` Greg KH
2010-08-06 4:50 ` Uwe Kleine-König [this message]
2010-08-06 8:46 ` Michał Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100806045046.GA13345@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.nazarewicz@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.