From: "Michał Nazarewicz" <m.nazarewicz@samsung.com>
To: linux-usb@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 1/2] usb gadget: don't save bind callback in struct usb_gadget_driver
Date: Thu, 05 Aug 2010 10:58:52 +0200 [thread overview]
Message-ID: <op.vgyi8eix7p4s8u@pikus> (raw)
In-Reply-To: <1280773666-5405-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Mon, 02 Aug 2010 20:27:45 +0200, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c
> @@ -2045,7 +2045,6 @@ static void __exit udc_exit(void)
> }
> EXPORT_SYMBOL(usb_gadget_unregister_driver);
> -EXPORT_SYMBOL(usb_gadget_register_driver);
*IF* you are going to send an updated patch, how about removing
empty line above this EXPORT_SYMBOL().
So for what it's worth the changes look good to me.
--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
next prev parent reply other threads:[~2010-08-05 8:57 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 14:49 [PATCH RFC] usb gadget: introduce usb_gadget_probe_driver Uwe Kleine-König
2010-07-30 14:49 ` Uwe Kleine-König
2010-07-30 15:14 ` Julia Lawall
2010-07-30 15:14 ` Julia Lawall
2010-07-30 15:28 ` Uwe Kleine-König
2010-07-30 15:28 ` Uwe Kleine-König
2010-07-30 15:16 ` Michał Nazarewicz
2010-07-30 15:16 ` Michał Nazarewicz
2010-07-30 15:26 ` Uwe Kleine-König
2010-07-30 15:26 ` Uwe Kleine-König
2010-07-30 16:08 ` Michał Nazarewicz
2010-07-30 16:08 ` Michał Nazarewicz
2010-07-30 18:57 ` Uwe Kleine-König
2010-07-30 18:57 ` Uwe Kleine-König
2010-07-30 18:46 ` David Brownell
2010-07-30 18:46 ` David Brownell
2010-08-02 9:39 ` Michał Nazarewicz
2010-08-02 9:39 ` Michał Nazarewicz
2010-08-02 12:39 ` [PATCH] usb gadget: don't save bind callback in struct usb_gadget_driver Uwe Kleine-König
2010-08-02 12:39 ` Uwe Kleine-König
2010-08-02 12:45 ` Christoph Hellwig
2010-08-02 12:51 ` Julia Lawall
2010-08-02 12:51 ` Julia Lawall
2010-08-02 13:12 ` Uwe Kleine-König
2010-08-02 13:12 ` Uwe Kleine-König
2010-08-02 22:54 ` Greg KH
2010-08-02 22:54 ` Greg KH
2010-08-03 7:40 ` Uwe Kleine-König
2010-08-02 14:25 ` Michał Nazarewicz
2010-08-02 14:25 ` Michał Nazarewicz
2010-08-02 18:25 ` Uwe Kleine-König
2010-08-02 18:27 ` [PATCH 1/2] " Uwe Kleine-König
2010-08-05 8:58 ` Michał Nazarewicz [this message]
2010-08-05 9:39 ` Uwe Kleine-König
2010-08-05 10:37 ` Michał Nazarewicz
2010-08-02 18:27 ` [PATCH 2/2] usb gadget: don't save bind callback in struct usb_configuration Uwe Kleine-König
2010-08-05 9:05 ` Michał Nazarewicz
2010-08-05 9:45 ` Uwe Kleine-König
2010-08-05 10:02 ` Michał Nazarewicz
2010-08-05 9:50 ` [PATCH 2/2 v2] " Uwe Kleine-König
2010-08-05 22:34 ` Greg KH
2010-08-06 4:50 ` Uwe Kleine-König
2010-08-06 8:46 ` Michał Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.vgyi8eix7p4s8u@pikus \
--to=m.nazarewicz@samsung.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.